Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/173111
Change subject: Hygiene: Make sure icon styles only run on older icons
......................................................................
Hygiene: Make sure icon styles only run on older icons
The min-height on rules such as icon-32px can interfere with alpha
styles.
Change-Id: Ia905261f0efc96f3a6975145741648c01157eb2c
---
M less/icons.less
1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/11/173111/1
diff --git a/less/icons.less b/less/icons.less
index 0431be9..115aaf0 100644
--- a/less/icons.less
+++ b/less/icons.less
@@ -81,18 +81,18 @@
// <div class="icon icon-16px icon-edit">edit</div>
//
// Styleguide 8.1.1
-.icon-16px {
+.icon.icon-16px {
.default-icon-size( 16px );
.background-size( 16px, auto );
}
// FIXME: Replace all instances of icon-18px with icon-16px
-.icon-18px {
+.icon.icon-18px {
.background-size( 18px, 18px );
}
// FIXME: Replace all instances of these icons with icon-16px or icon-24px
-.icon-20px {
+.icon.icon-20px {
.background-size( auto, 20px );
}
@@ -106,11 +106,11 @@
// <div class="icon icon-32px icon-edit"
style="width:32px;height:32px;">edit</div>
//
// Styleguide 8.1.2.
-.loading,
+.icon.loading,
// FIXME: Make the ajax loader a View with the icon-32px class
-.mw-ui-button.mw-ui-progressive.icon-32px,
+.icon.mw-ui-button.mw-ui-progressive.icon-32px,
// FIXME: Kill above when mediawiki ui buttons does not use background
declaration
-.icon-32px {
+.icon.icon-32px {
.background-size( 32px, auto );
.default-icon-size( 32px );
}
--
To view, visit https://gerrit.wikimedia.org/r/173111
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia905261f0efc96f3a6975145741648c01157eb2c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
