Arlolra has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/173212

Change subject: Don't allow quotes in generic_attribute_name
......................................................................

Don't allow quotes in generic_attribute_name

 * They're invalid characters.

 * Need to think about this a little more, particularly:

   - Should these be added to broken_table_attribute_name_char?

   - How will affect broken single line attribute values also using this
     production?

 * Fixes the crasher in:
   enwiki/List_of_Linux_distributions_that_run_from_RAM?oldid=633661716

Change-Id: Idd7f8f0103bac6928d217352b355b41a3af21f2b
---
M lib/pegTokenizer.pegjs.txt
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid 
refs/changes/12/173212/1

diff --git a/lib/pegTokenizer.pegjs.txt b/lib/pegTokenizer.pegjs.txt
index c857da1..42addbf 100644
--- a/lib/pegTokenizer.pegjs.txt
+++ b/lib/pegTokenizer.pegjs.txt
@@ -2197,7 +2197,7 @@
               // Eat insane tags-inside-attributes. Example:
               // <hiddentext>generated with.. </hiddentext>
               / &generic_tag nb:nested_block_line { return nb; }
-              / !(space_or_newline / [\[=>]) c:. {
+              / !(space_or_newline / [\[=>"']) c:. {
                     //console.warn( 'aptl: ' + pp(c) );
                     return c;
                 }

-- 
To view, visit https://gerrit.wikimedia.org/r/173212
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idd7f8f0103bac6928d217352b355b41a3af21f2b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Arlolra <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to