Florianschmidtwelzow has uploaded a new change for review.
https://gerrit.wikimedia.org/r/173283
Change subject: Hygiene: Remove mw-ui-block from links
......................................................................
Hygiene: Remove mw-ui-block from links
According to discussion on change:
I1267c838aaa93d3ec4b22577fe959764ba2d11f3
Change-Id: I1991993ec9933df64a0ef8fe9ddafadec1fd8d56
---
M less/drawer.less
M templates/ctaDrawer.hogan
2 files changed, 10 insertions(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/83/173283/1
diff --git a/less/drawer.less b/less/drawer.less
index 3309bc1..e33924a 100644
--- a/less/drawer.less
+++ b/less/drawer.less
@@ -38,6 +38,7 @@
}
p,
+ div:not(:last-child),
a:not(:last-child),
.mw-ui-button {
margin-bottom: 1em;
@@ -52,12 +53,6 @@
height: 32px;
background-position: 50% 8px;
}
- }
-
- // Special handling of CtaDrawer for anonymous editing
- // FIXME: remove when mw-ui-block allowed for anchors
- .mw-ui-block {
- display: block;
}
}
diff --git a/templates/ctaDrawer.hogan b/templates/ctaDrawer.hogan
index a25d6dc..f6363d1 100644
--- a/templates/ctaDrawer.hogan
+++ b/templates/ctaDrawer.hogan
@@ -1,9 +1,15 @@
{{{collapseButton}}}
<p>{{content}}</p>
<div class="mw-ui-button-group">
- <a class="mw-ui-button mw-ui-block mw-ui-progressive"
href="{{loginUrl}}">{{loginCaption}}</a>
- <a class="mw-ui-progressive mw-ui-anchor mw-ui-block"
href="{{signupUrl}}">{{signupCaption}}</a>
+ <div>
+ <a class="mw-ui-button mw-ui-block mw-ui-progressive"
href="{{loginUrl}}">{{loginCaption}}</a>
+ </div>
+ <div>
+ <a class="mw-ui-progressive mw-ui-anchor mw-ui-block"
href="{{signupUrl}}">{{signupCaption}}</a>
+ </div>
{{#links}}
- <a class="mw-ui-anchor mw-ui-block {{selector}}"
href="{{href}}">{{label}}</a>
+ <div>
+ <a class="mw-ui-anchor mw-ui-block {{selector}}"
href="{{href}}">{{label}}</a>
+ </div>
{{/links}}
</div>
--
To view, visit https://gerrit.wikimedia.org/r/173283
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1991993ec9933df64a0ef8fe9ddafadec1fd8d56
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
