Cmcmahon has uploaded a new change for review.
https://gerrit.wikimedia.org/r/173345
Change subject: [BrowserTest] modern RSpec syntax and making regexes nicer
......................................................................
[BrowserTest] modern RSpec syntax and making regexes nicer
Change-Id: I987f5b8f4771785a9b38ae1ac57e9b2806cf4bc1
---
M modules/ve-mw/tests/browser/features/step_definitions/links_steps.rb
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/45/173345/1
diff --git
a/modules/ve-mw/tests/browser/features/step_definitions/links_steps.rb
b/modules/ve-mw/tests/browser/features/step_definitions/links_steps.rb
index 8b4e6dd..22ab954 100644
--- a/modules/ve-mw/tests/browser/features/step_definitions/links_steps.rb
+++ b/modules/ve-mw/tests/browser/features/step_definitions/links_steps.rb
@@ -46,7 +46,7 @@
page.wait_until(10) do
page.diff_view.include? "DoesNotExist"
end
- page.diff_view.should match Regexp.escape("[[DoesNotExist|Links]]")
+ expect(page.diff_view).to match /\[\[DoesNotExist|Links\]/
end
end
@@ -55,7 +55,7 @@
page.wait_until(10) do
page.diff_view.include? "example.com"
end
- page.diff_view.should match Regexp.escape("[http://www.example.com Links]")
+ expect(page.diff_view).to match /\[http:\/\/www.example.com Links\]/
end
end
@@ -64,6 +64,6 @@
page.wait_until(10) do
page.diff_view.include? "Main Page"
end
- page.diff_view.should match Regexp.escape("[[Main Page|Links]]")
+ expect(page.diff_view).to match /\[\[Main Page|Links\]\]/
end
end
--
To view, visit https://gerrit.wikimedia.org/r/173345
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I987f5b8f4771785a9b38ae1ac57e9b2806cf4bc1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
