jenkins-bot has submitted this change and it was merged.
Change subject: Hygiene: Remove unused method don't expose methods we are not
using.
......................................................................
Hygiene: Remove unused method don't expose methods we are not using.
* unlockViewport and prettyEncodeTitle are not used anywhere.
deparam is only run in application.js so does not need to be exposed.
Change-Id: Iab8e3c80f70858dfe3e9749f3c125d100faad4a4
---
M javascripts/Overlay.js
M javascripts/application.js
2 files changed, 1 insertion(+), 24 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/javascripts/Overlay.js b/javascripts/Overlay.js
index cd2fcaf..fda08b8 100644
--- a/javascripts/Overlay.js
+++ b/javascripts/Overlay.js
@@ -176,8 +176,6 @@
hide: function ( force ) {
var self = this;
- // FIXME: allow zooming outside the overlay again
- // M.unlockViewport();
// FIXME: remove when OverlayManager used everywhere
if ( this.parent ) {
this.parent.show();
diff --git a/javascripts/application.js b/javascripts/application.js
index 84315e5..aa69d11 100644
--- a/javascripts/application.js
+++ b/javascripts/application.js
@@ -106,15 +106,6 @@
}
/**
- * Unlocks viewport so that pinch zooming is enabled
- *
- * @method
- */
- function unlockViewport() {
- $viewportMeta.attr( 'content', viewport );
- }
-
- /**
* Tests current window size and if suitable loads styles and scripts
specific for larger devices
* FIXME: Separate from application.js
*
@@ -268,15 +259,6 @@
}
/**
- * Tidy up a page title
- * @method
- * @return {String}
- */
- function prettyEncodeTitle( title ) {
- return encodeURIComponent( title.replace( / /g, '_' )
).replace( /%3A/g, ':' ).replace( /%2F/g, '/' );
- }
-
- /**
* FIXME: sandbox from mf-application.js
*
* @method
@@ -319,7 +301,7 @@
return sessionId;
}
- /**
+ /*
* Takes a Query string and turns it into a JavaScript object mapping
parameter names
* to values. Does the opposite of $.param
*
@@ -417,9 +399,7 @@
supportsPositionFixed: supportsPositionFixed,
isIos: isIos,
isIos8: isIos8,
- prettyEncodeTitle: prettyEncodeTitle,
query: deParam( qs ),
- unlockViewport: unlockViewport,
/**
* Navigation router instance
* @type {Router}
@@ -435,7 +415,6 @@
* @type {PageApi}
*/
pageApi: pageApi,
- deParam: deParam,
/**
* User Bucketing for A/B testing
** (we want this to be the same everywhere)
--
To view, visit https://gerrit.wikimedia.org/r/173339
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab8e3c80f70858dfe3e9749f3c125d100faad4a4
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: Bmansurov <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
