jenkins-bot has submitted this change and it was merged.
Change subject: Fix editing of ranks
......................................................................
Fix editing of ranks
Bug: 73307
Change-Id: I9e48cc31b95b4f4a5fc1a81be669064f49bcd9c0
---
M lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Henning Snater: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
index fa381c7..02afc57 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
@@ -535,7 +535,9 @@
function stopEditing() {
self._isInEditMode = false;
- self._claimview.stopEditing( dropValue );
+ // If the claimview has it's initial value, it
refuses to leave edit mode.
+ // Set dropValue = true in this case, so that
it really leaves edit mode.
+ self._claimview.stopEditing(
self._claimview.isInitialValue() || dropValue );
self.enable();
self.element.removeClass( 'wb-edit' );
--
To view, visit https://gerrit.wikimedia.org/r/172976
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e48cc31b95b4f4a5fc1a81be669064f49bcd9c0
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang <[email protected]>
Gerrit-Reviewer: Adrian Lang <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Henning Snater <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
