Yuvipanda has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/173870

Change subject: diamond: Explicitly set method to use for determining hostname
......................................................................

diamond: Explicitly set method to use for determining hostname

Currently, tools-webproxy.eqiad.wmflabs gets reported as
just tools to graphite, causing issues with shinken (and anything
else that assumes name of host is name of metric in graphite).
This explicitly sets the method to use as hostname, so we
consistently get the same results everywhere.

Change-Id: I08927cf0501a45bd9e776aa79e1fc4bd6cf01217
---
M modules/diamond/templates/diamond.conf.erb
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/70/173870/1

diff --git a/modules/diamond/templates/diamond.conf.erb 
b/modules/diamond/templates/diamond.conf.erb
index 6e07f19..6403288 100644
--- a/modules/diamond/templates/diamond.conf.erb
+++ b/modules/diamond/templates/diamond.conf.erb
@@ -22,6 +22,7 @@
 ### Defaults options for all Collectors
 path_prefix = <%= @path_prefix %>
 interval = <%= @interval %>
+hostname_method = hostname # Explicitly set to fix undeterministic names for 
some public machines
 
 [loggers]
 

-- 
To view, visit https://gerrit.wikimedia.org/r/173870
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I08927cf0501a45bd9e776aa79e1fc4bd6cf01217
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Yuvipanda <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to