jenkins-bot has submitted this change and it was merged.
Change subject: Change document order of tools and actions to fix floating
......................................................................
Change document order of tools and actions to fix floating
For float to work properly it should come before the inline content.
Admittedly this makes things a little backwards for keyboard accessibility,
but I can't see a way to achieve this layout otherwise (specifically
having the tools wrapping with display: inline).
Change-Id: Id9597fde9cf8667919b121ab78b2c02ca25a5c54
---
M src/Toolbar.js
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
Trevor Parscal: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/Toolbar.js b/src/Toolbar.js
index 416a544..1c0af2d 100644
--- a/src/Toolbar.js
+++ b/src/Toolbar.js
@@ -40,12 +40,10 @@
// Initialization
this.$group.addClass( 'oo-ui-toolbar-tools' );
- this.$bar.addClass( 'oo-ui-toolbar-bar' ).append( this.$group );
if ( config.actions ) {
- this.$actions.addClass( 'oo-ui-toolbar-actions' );
- this.$bar.append( this.$actions );
+ this.$bar.append( this.$actions.addClass(
'oo-ui-toolbar-actions' ) );
}
- this.$bar.append( '<div style="clear:both"></div>' );
+ this.$bar.append( this.$group, '<div style="clear:both"></div>' );
if ( config.shadow ) {
this.$bar.append( '<div class="oo-ui-toolbar-shadow"></div>' );
}
--
To view, visit https://gerrit.wikimedia.org/r/173331
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id9597fde9cf8667919b121ab78b2c02ca25a5c54
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Trevor Parscal <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
