jenkins-bot has submitted this change and it was merged.

Change subject: Fix tracking for version
......................................................................


Fix tracking for version

* wikiapiary does not detect the version so this way fixes the issue.

Note this has been tested.

Change-Id: I2ad43801cc71285cad8576657c5dc5e4668a37b3
---
M SyntaxHighlight_GeSHi.class.php
M SyntaxHighlight_GeSHi.php
2 files changed, 3 insertions(+), 14 deletions(-)

Approvals:
  Raimond Spekking: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/SyntaxHighlight_GeSHi.class.php b/SyntaxHighlight_GeSHi.class.php
index 7ac0611..2216a4d 100644
--- a/SyntaxHighlight_GeSHi.class.php
+++ b/SyntaxHighlight_GeSHi.class.php
@@ -508,18 +508,6 @@
        }
 
        /**
-        * Get the GeSHI's version information while Special:Version is read.
-        * @param $extensionTypes
-        * @return bool
-        */
-       public static function extensionTypes( &$extensionTypes ) {
-               global $wgExtensionCredits;
-               self::initialise();
-               
$wgExtensionCredits['parserhook']['SyntaxHighlight_GeSHi']['version'] = 
GESHI_VERSION;
-               return true;
-       }
-
-       /**
         * Register a ResourceLoader module providing styles for each supported 
language.
         *
         * @param ResourceLoader $resourceLoader
diff --git a/SyntaxHighlight_GeSHi.php b/SyntaxHighlight_GeSHi.php
index de2c76b..9a3bc97 100644
--- a/SyntaxHighlight_GeSHi.php
+++ b/SyntaxHighlight_GeSHi.php
@@ -40,13 +40,15 @@
        die( "This version of SyntaxHighlight GeSHi requires MediaWiki 1.24" );
 }
 
+define('GESHI_VERSION', '1.0.8.12');
 
-$wgExtensionCredits['parserhook']['SyntaxHighlight_GeSHi'] = array(
+$wgExtensionCredits['parserhook'][] = array(
        'path'           => __FILE__,
        'name'           => 'SyntaxHighlight',
        'author'         => array( 'Brion Vibber', 'Tim Starling', 'Rob 
Church', 'Niklas Laxström' ),
        'descriptionmsg' => 'syntaxhighlight-desc',
        'url'            => 
'https://www.mediawiki.org/wiki/Extension:SyntaxHighlight_GeSHi',
+       'version'        => GESHI_VERSION,
 );
 
 // Change these in LocalSettings.php
@@ -61,7 +63,6 @@
 $wgAutoloadClasses['ResourceLoaderGeSHiModule'] = $dir . 
'ResourceLoaderGeSHiModule.php';
 $wgAutoloadClasses['ResourceLoaderGeSHiLocalModule'] = $dir . 
'ResourceLoaderGeSHiLocalModule.php';
 
-$wgHooks['ExtensionTypes'][] = 'SyntaxHighlight_GeSHi::extensionTypes';
 $wgHooks['ResourceLoaderRegisterModules'][] = 
'SyntaxHighlight_GeSHi::resourceLoaderRegisterModules';
 $wgHooks['ContentGetParserOutput'][] = 'SyntaxHighlight_GeSHi::renderHook';
 $wgHooks['ApiFormatHighlight'][] = 'SyntaxHighlight_GeSHi::apiFormatHighlight';

-- 
To view, visit https://gerrit.wikimedia.org/r/172581
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2ad43801cc71285cad8576657c5dc5e4668a37b3
Gerrit-PatchSet: 7
Gerrit-Project: mediawiki/extensions/SyntaxHighlight_GeSHi
Gerrit-Branch: master
Gerrit-Owner: Paladox <[email protected]>
Gerrit-Reviewer: Paladox <[email protected]>
Gerrit-Reviewer: Raimond Spekking <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: TheDJ <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to