jenkins-bot has submitted this change and it was merged.
Change subject: Update type hint in interface
......................................................................
Update type hint in interface
Change-Id: Iede16f8e8386bb94ceeed04fcc317f65dcecaca7
---
M lib/includes/store/EntityLookup.php
M lib/includes/store/RedirectResolvingEntityLookup.php
M lib/includes/store/RevisionBasedEntityLookup.php
M lib/tests/phpunit/MockRepository.php
4 files changed, 8 insertions(+), 7 deletions(-)
Approvals:
Adrian Lang: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/includes/store/EntityLookup.php
b/lib/includes/store/EntityLookup.php
index 52e6a54..b8c941a 100644
--- a/lib/includes/store/EntityLookup.php
+++ b/lib/includes/store/EntityLookup.php
@@ -2,7 +2,7 @@
namespace Wikibase\Lib\Store;
-use Wikibase\DataModel\Entity\Entity;
+use Wikibase\DataModel\Entity\EntityDocument;
use Wikibase\DataModel\Entity\EntityId;
/**
@@ -29,7 +29,7 @@
* @param EntityId $entityId
*
* @throws StorageException
- * @return Entity|null
+ * @return EntityDocument|null
*/
public function getEntity( EntityId $entityId );
diff --git a/lib/includes/store/RedirectResolvingEntityLookup.php
b/lib/includes/store/RedirectResolvingEntityLookup.php
index 9b33c3c..b52e7a3 100644
--- a/lib/includes/store/RedirectResolvingEntityLookup.php
+++ b/lib/includes/store/RedirectResolvingEntityLookup.php
@@ -2,7 +2,7 @@
namespace Wikibase\Lib\Store;
-use Wikibase\DataModel\Entity\Entity;
+use Wikibase\DataModel\Entity\EntityDocument;
use Wikibase\DataModel\Entity\EntityId;
/**
@@ -44,7 +44,7 @@
* @param EntityId $entityId
*
* @throws StorageException
- * @return Entity|null
+ * @return EntityDocument|null
*/
public function getEntity( EntityId $entityId ) {
return $this->lookup->getEntity( $entityId );
diff --git a/lib/includes/store/RevisionBasedEntityLookup.php
b/lib/includes/store/RevisionBasedEntityLookup.php
index ef455a3..d9922b4 100644
--- a/lib/includes/store/RevisionBasedEntityLookup.php
+++ b/lib/includes/store/RevisionBasedEntityLookup.php
@@ -2,7 +2,7 @@
namespace Wikibase\Lib\Store;
-use Wikibase\DataModel\Entity\Entity;
+use Wikibase\DataModel\Entity\EntityDocument;
use Wikibase\DataModel\Entity\EntityId;
/**
@@ -35,7 +35,7 @@
* @param EntityId $entityId
*
* @throws StorageException
- * @return Entity|null
+ * @return EntityDocument|null
*/
public function getEntity( EntityId $entityId ) {
$revision = $this->lookup->getEntityRevision( $entityId );
diff --git a/lib/tests/phpunit/MockRepository.php
b/lib/tests/phpunit/MockRepository.php
index a4b9ef9..c82a5f8 100644
--- a/lib/tests/phpunit/MockRepository.php
+++ b/lib/tests/phpunit/MockRepository.php
@@ -7,6 +7,7 @@
use User;
use Wikibase\DataModel\Entity\BasicEntityIdParser;
use Wikibase\DataModel\Entity\Entity;
+use Wikibase\DataModel\Entity\EntityDocument;
use Wikibase\DataModel\Entity\EntityId;
use Wikibase\DataModel\Entity\Item;
use Wikibase\DataModel\Entity\ItemId;
@@ -93,7 +94,7 @@
*
* @param EntityID $entityId
*
- * @return Entity|null
+ * @return EntityDocument|null
*
* @throws StorageException
*/
--
To view, visit https://gerrit.wikimedia.org/r/173815
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iede16f8e8386bb94ceeed04fcc317f65dcecaca7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Adrian Lang <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
