Hashar has submitted this change and it was merged.
Change subject: Fixed RuboCop Style/SignalException offense
......................................................................
Fixed RuboCop Style/SignalException offense
Bug: 72841
Change-Id: Ibea1bbf8bb9a34ee8fa6852899754c1436e0ad30
---
M .rubocop_todo.yml
M bin/docparser.rb
2 files changed, 1 insertion(+), 7 deletions(-)
Approvals:
Hashar: Looks good to me, approved
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 93a9fcb..59c62a5 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -96,12 +96,6 @@
Style/RegexpLiteral:
MaxSlashes: 3
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/SignalException:
- Enabled: false
-
# Offense count: 2
# Cop supports --auto-correct.
Style/SpaceAfterComma:
diff --git a/bin/docparser.rb b/bin/docparser.rb
index b82c0db..0955df5 100644
--- a/bin/docparser.rb
+++ b/bin/docparser.rb
@@ -148,7 +148,7 @@
when 'abstract', 'inheritable', 'deprecated',
'singleton', 'throws', 'chainable', 'fires', 'localdoc', 'inheritdoc'
# skip
else
- raise "unrecognized keyword: #{keyword}"
+ fail "unrecognized keyword: #{keyword}"
end
}
--
To view, visit https://gerrit.wikimedia.org/r/172733
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibea1bbf8bb9a34ee8fa6852899754c1436e0ad30
Gerrit-PatchSet: 3
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <[email protected]>
Gerrit-Reviewer: Dduvall <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
