Rush has submitted this change and it was merged.

Change subject: phab don't try to preview icon/x-icon
......................................................................


phab don't try to preview icon/x-icon

refs T1296

Change-Id: I48777c578ed370d90ac29bdc03c5ccde0a59feb1
---
M modules/phabricator/data/fixed_settings.yaml
1 file changed, 23 insertions(+), 0 deletions(-)

Approvals:
  Rush: Verified; Looks good to me, approved
  Aklapper: Looks good to me, but someone else must approve



diff --git a/modules/phabricator/data/fixed_settings.yaml 
b/modules/phabricator/data/fixed_settings.yaml
index 0fe254d..e7ccf0e 100644
--- a/modules/phabricator/data/fixed_settings.yaml
+++ b/modules/phabricator/data/fixed_settings.yaml
@@ -12,6 +12,29 @@
   - {href: 'https://wikimediafoundation.org/wiki/Terms_of_Use/Phabricator', 
name: Terms of Use}
   - {href: 
'https://wikimediafoundation.org/wiki/Wikimedia:General_disclaimer', name: 
Disclaimer}
 
+# Due to issues with 'gd' rending thumbnails for
+# Mimetype image/x-icon and image/icon
+# Disabling previews for icons for now
+# https://secure.phabricator.com/T6573
+files.viewable-mime-types:
+  'image/jpeg': 'image/jpeg'
+  'image/jpg': 'image/jpg'
+  'image/png': 'image/png'
+  'image/gif': 'image/gif'
+  'text/plain': 'text/plain; charset=utf-8'
+  'text/x-diff': "text/plain; charset=utf-8'
+  'image/vnd.microsoft.icon': 'image/x-icon'
+  'audio/x-wav': 'audio/x-wav'
+  'application/ogg': 'application/ogg'
+  'audio/mpeg': 'audio/mpeg'
+
+files.image-mime-types:
+  image/jpeg
+  image/jpg
+  image/png
+  image/gif
+  image/vnd.microsoft.icon
+
 maniphest.priorities:
   '100':
     name: 'Unbreak Now!'

-- 
To view, visit https://gerrit.wikimedia.org/r/173875
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I48777c578ed370d90ac29bdc03c5ccde0a59feb1
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Rush <[email protected]>
Gerrit-Reviewer: Aklapper <[email protected]>
Gerrit-Reviewer: Rush <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to