Hello Ori.livneh,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/174328
to review the following change.
Change subject: Revert "Fix for multi-row INSERT capability test"
......................................................................
Revert "Fix for multi-row INSERT capability test"
EventLogging's mysql-m2-consumer is currently failing a lot with
RuntimeError: maximum recursion depth exceeded while calling a Python object
and in the stack-traces, eventlogging/utils.py:28 is occurring a
lot. It seems this error also grabs all available memory, and OOM gets
active.
So it seems the multi-inserts are not morking smoothly, and we revert
for now.
This reverts commit dc8a99931948ecde9a7e730f080a3bb2191721ef.
Change-Id: I1ceb9e0542e9d9a27e2eb32838880b45467f4f43
---
M server/eventlogging/jrm.py
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EventLogging
refs/changes/28/174328/1
diff --git a/server/eventlogging/jrm.py b/server/eventlogging/jrm.py
index 4f25bee..09c5fae 100644
--- a/server/eventlogging/jrm.py
+++ b/server/eventlogging/jrm.py
@@ -199,8 +199,7 @@
queue = [events.pop() for _ in range(len(events))]
queue.sort(key=get_scid)
- if (getattr(meta.bind.dialect, 'supports_multivalues_insert', False)
- or getattr(meta.bind.dialect, 'supports_multirow_insert', False)):
+ if meta.bind.dialect.supports_multivalues_insert:
insert = _insert_multi
else:
insert = _insert_sequential
--
To view, visit https://gerrit.wikimedia.org/r/174328
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ceb9e0542e9d9a27e2eb32838880b45467f4f43
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: QChris <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
