Pcoombe has submitted this change and it was merged.
Change subject: Stop clobbering reason from alterImpressionData
......................................................................
Stop clobbering reason from alterImpressionData
My last change to impression recording overwrote reasons set by
banner-specific alterImpressionData functions. This should let
those back through.
Change-Id: Ifb4a6c01ce894408b0eb86587bcb5eb130d615bd
---
M modules/ext.centralNotice.bannerController/bannerController.js
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Pcoombe: Looks good to me, approved
diff --git a/modules/ext.centralNotice.bannerController/bannerController.js
b/modules/ext.centralNotice.bannerController/bannerController.js
index 1069335..79eb55a 100644
--- a/modules/ext.centralNotice.bannerController/bannerController.js
+++ b/modules/ext.centralNotice.bannerController/bannerController.js
@@ -434,7 +434,11 @@
// ~~ as of 2012-11-27
if ( !bannerShown ) {
hideBanner = true;
- impressionData.reason =
'alterImpressionData';
+ // alterImpressionData should set a
reason, but we'll set a
+ // default if it didn't
+ if ( !impressionData.reason ) {
+ impressionData.reason =
'alterImpressionData';
+ }
}
}
}
--
To view, visit https://gerrit.wikimedia.org/r/174319
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb4a6c01ce894408b0eb86587bcb5eb130d615bd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Ejegg <[email protected]>
Gerrit-Reviewer: Awight <[email protected]>
Gerrit-Reviewer: Ejegg <[email protected]>
Gerrit-Reviewer: Ewulczyn <[email protected]>
Gerrit-Reviewer: Katie Horn <[email protected]>
Gerrit-Reviewer: Mwalker <[email protected]>
Gerrit-Reviewer: Pcoombe <[email protected]>
Gerrit-Reviewer: Ssmith <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
