MaxSem has uploaded a new change for review.
https://gerrit.wikimedia.org/r/174611
Change subject: Revert "Add footer logo dimensions"
......................................................................
Revert "Add footer logo dimensions"
Making a HTTP request on every page view in not accptable from a performance
point of view.
This reverts commit e392dd7c4d44b85b52137ea473c56ca20d31fc68.
Change-Id: I8249de74eaa12edb2abb2dbf78d6a8f4217537d4
---
M images/logo-copyright-en.png
M includes/skins/SkinMinerva.php
M less/footer.less
3 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/11/174611/1
diff --git a/images/logo-copyright-en.png b/images/logo-copyright-en.png
index 495e11a..03f7334 100644
--- a/images/logo-copyright-en.png
+++ b/images/logo-copyright-en.png
Binary files differ
diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index 72ec038..6276e17 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -1028,13 +1028,9 @@
if ( isset( $wgMFCustomLogos['copyright'] ) ) {
$suffix = $wgMFTrademarkSitename ? ' ®' : '';
- $imageSize = getimagesize(
$wgMFCustomLogos['copyright'] );
$sitename = Html::element( 'img', array(
'src' => $wgMFCustomLogos['copyright'],
- 'alt' => $footerSitename . $suffix,
- // support retina
- 'width' => $imageSize[0] / ( $imageSize[1] / 15
),
- 'height' => 15
+ 'alt' => $footerSitename . $suffix
) );
} else {
$suffix = $wgMFTrademarkSitename ? ' ™' : '';
diff --git a/less/footer.less b/less/footer.less
index 45fadbe..7784004 100644
--- a/less/footer.less
+++ b/less/footer.less
@@ -17,6 +17,10 @@
display: inline;
font-weight: bold;
font-size: 1em;
+
+ img {
+ height: 1em;
+ }
}
ul {
--
To view, visit https://gerrit.wikimedia.org/r/174611
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8249de74eaa12edb2abb2dbf78d6a8f4217537d4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: MaxSem <maxsem.w...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
