jenkins-bot has submitted this change and it was merged. Change subject: QA: wait for element to appear ......................................................................
QA: wait for element to appear prevent false failures like https://integration.wikimedia.org/ci/view/BrowserTests/view/-All/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/lastCompletedBuild/testReport/(root)/Download%20menu/The_medium_download_option_has_the_correct_information/ Change-Id: I122a82a5ec802c0c0eec90b55757153a2ab58ef7 --- M tests/browser/features/step_definitions/mmv_download_steps.rb 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gergő Tisza: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/browser/features/step_definitions/mmv_download_steps.rb b/tests/browser/features/step_definitions/mmv_download_steps.rb index c5bd530..dc2188a 100644 --- a/tests/browser/features/step_definitions/mmv_download_steps.rb +++ b/tests/browser/features/step_definitions/mmv_download_steps.rb @@ -46,7 +46,7 @@ @index = 0 end - page.mmv_download_size_options_elements[@index].click + page.mmv_download_size_options_elements[@index].when_present.click end end -- To view, visit https://gerrit.wikimedia.org/r/174790 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I122a82a5ec802c0c0eec90b55757153a2ab58ef7 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MultimediaViewer Gerrit-Branch: master Gerrit-Owner: Cmcmahon <cmcma...@wikimedia.org> Gerrit-Reviewer: Gergő Tisza <gti...@wikimedia.org> Gerrit-Reviewer: Gilles <gdu...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
