Tim Landscheidt has uploaded a new change for review.
https://gerrit.wikimedia.org/r/174852
Change subject: Fix error in UIDGeneratorTest::testTimestampedUID
......................................................................
Fix error in UIDGeneratorTest::testTimestampedUID
Currently, this test passes in Jenkins, but not in Travis CI where
apparently code execution is slower so not all UIDs are created within
the same millisecond.
Bug: 73668
Change-Id: Ic68af599599ace5faa6a687d115d2d3802f6ba1b
---
M tests/phpunit/includes/utils/UIDGeneratorTest.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/52/174852/1
diff --git a/tests/phpunit/includes/utils/UIDGeneratorTest.php
b/tests/phpunit/includes/utils/UIDGeneratorTest.php
index 50fa384..997fa70 100644
--- a/tests/phpunit/includes/utils/UIDGeneratorTest.php
+++ b/tests/phpunit/includes/utils/UIDGeneratorTest.php
@@ -35,8 +35,8 @@
$lastId_bin = wfBaseConvert( $lastId, 10, 2 );
$this->assertGreaterThanOrEqual(
- substr( $id_bin, 0, $tbits ),
substr( $lastId_bin, 0, $tbits ),
+ substr( $id_bin, 0, $tbits ),
"New ID timestamp ($id_bin) >= prior one
($lastId_bin)." );
if ( $hostbits ) {
--
To view, visit https://gerrit.wikimedia.org/r/174852
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic68af599599ace5faa6a687d115d2d3802f6ba1b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Tim Landscheidt <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
