Smuggli has submitted this change and it was merged.
Change subject: Fixed issue with wrong id format
......................................................................
Fixed issue with wrong id format
Since the id of the element has changed due to testing purpose, a string was
passed and an int was expected.
* Removed accidently added change which caused problems
Patchset 3: Added id handling for select boxes
Change-Id: I3cec5bc79f6c35734411ffc0217c4fd45867b686
---
M Checklist/resources/bluespice.checklist.js
1 file changed, 11 insertions(+), 4 deletions(-)
Approvals:
Mglaser: Verified
Smuggli: Verified; Looks good to me, approved
diff --git a/Checklist/resources/bluespice.checklist.js
b/Checklist/resources/bluespice.checklist.js
index bfe2b19..a957b26 100644
--- a/Checklist/resources/bluespice.checklist.js
+++ b/Checklist/resources/bluespice.checklist.js
@@ -27,13 +27,17 @@
},
click: function(elem) {
+ var id = elem.id;
+ id = id.split( "-" );
+ id = id.pop();
+
$.ajax({
type: "GET",
url: bs.util.getAjaxDispatcherUrl(
'Checklist::doChangeCheckItem' ),
data: {
- pos:elem.id,
- value:elem.checked,
- articleId:mw.config.get('wgArticleId')
+ pos: id,
+ value: elem.checked,
+ articleId: mw.config.get('wgArticleId')
},
//dataType: 'html',
success: function(result){ // the returned value is
passed back as a _result_
@@ -43,12 +47,15 @@
},
change: function(elem) {
+ var id = elem.id;
+ id = id.split( "-" );
+ id = id.pop();
elem.style.color=elem.options[elem.selectedIndex].style.color;
$.ajax({
type: "GET",
url: bs.util.getAjaxDispatcherUrl(
'Checklist::doChangeCheckItem' ),
data: {
- pos:elem.id,
+ pos: id,
value:$('#'+elem.id).find(":selected").text(),
articleId:mw.config.get('wgArticleId')
},
--
To view, visit https://gerrit.wikimedia.org/r/173800
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3cec5bc79f6c35734411ffc0217c4fd45867b686
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: master
Gerrit-Owner: Smuggli <mug...@hallowelt.biz>
Gerrit-Reviewer: Mglaser <gla...@hallowelt.biz>
Gerrit-Reviewer: Pigpen <reym...@hallowelt.biz>
Gerrit-Reviewer: Robert Vogel <vo...@hallowelt.biz>
Gerrit-Reviewer: Smuggli <mug...@hallowelt.biz>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
