Cmcmahon has uploaded a new change for review.
https://gerrit.wikimedia.org/r/174975
Change subject: [BrowserTest] comments for classes
......................................................................
[BrowserTest] comments for classes
Change-Id: I3d5e063ee4dd36632ab9c2a433660567b70777ea
---
M .rubocop_todo.yml
M modules/ve-mw/tests/browser/features/support/pages/dummy_page.rb
D modules/ve-mw/tests/browser/features/support/pages/user_page.rb
M modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
M modules/ve-mw/tests/browser/features/support/pages/zarticlepage.rb
5 files changed, 3 insertions(+), 12 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/75/174975/1
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index cf265f1..a45077f 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -27,10 +27,6 @@
Metrics/MethodLength:
Max: 18
-# Offense count: 4
-Style/Documentation:
- Enabled: false
-
# Offense count: 3
# Configuration parameters: AllowedVariables.
Style/GlobalVars:
diff --git a/modules/ve-mw/tests/browser/features/support/pages/dummy_page.rb
b/modules/ve-mw/tests/browser/features/support/pages/dummy_page.rb
index 11f099a..54e4cdd 100644
--- a/modules/ve-mw/tests/browser/features/support/pages/dummy_page.rb
+++ b/modules/ve-mw/tests/browser/features/support/pages/dummy_page.rb
@@ -1,3 +1,4 @@
+# This is used in the verify_production_wikis test
class DummyPage
include PageObject
diff --git a/modules/ve-mw/tests/browser/features/support/pages/user_page.rb
b/modules/ve-mw/tests/browser/features/support/pages/user_page.rb
deleted file mode 100644
index a7c80be..0000000
--- a/modules/ve-mw/tests/browser/features/support/pages/user_page.rb
+++ /dev/null
@@ -1,8 +0,0 @@
-class UserPage
- include PageObject
-
- include URL
- page_url URL.url('<%=params[:page_title]%>')
-
- div(:ve_editing_surface, class: 've-ui-surface
ve-init-mw-viewPageTarget-surface')
-end
diff --git
a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
index 9b08946..b0b2b97 100644
--- a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
+++ b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
@@ -1,3 +1,4 @@
+# This is the main page for VisualEditor
class VisualEditorPage
include PageObject
include URL
diff --git a/modules/ve-mw/tests/browser/features/support/pages/zarticlepage.rb
b/modules/ve-mw/tests/browser/features/support/pages/zarticlepage.rb
index ed379ff..732dd2d 100644
--- a/modules/ve-mw/tests/browser/features/support/pages/zarticlepage.rb
+++ b/modules/ve-mw/tests/browser/features/support/pages/zarticlepage.rb
@@ -1,3 +1,4 @@
+# This page object exists because logged in users should not see these URL
params
class ZtargetPage < VisualEditorPage
include URL
page_url
URL.url('<%=params[:article_name]%>?vehidebetadialog=true&veaction=edit')
--
To view, visit https://gerrit.wikimedia.org/r/174975
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d5e063ee4dd36632ab9c2a433660567b70777ea
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon <cmcma...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
