Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/175125
Change subject: Consistently use ve.ui.WindowManager everywhere
......................................................................
Consistently use ve.ui.WindowManager everywhere
We were using OO.ui.WindowManager except where we absolutely
needed to use ve.ui.WindowManager. Instead, consistently
use VE's WindowManager class everywhere in VE, so future
customizations to ve.ui.WindowManager will be applied
everywhere in VE.
Change-Id: Id6660a4b54a496eefa6c79e162570d402f95eab5
---
M src/ui/ve.ui.Context.js
M src/ui/ve.ui.DesktopSurface.js
M src/ui/ve.ui.Surface.js
M src/ui/widgets/ve.ui.LanguageInputWidget.js
4 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/25/175125/1
diff --git a/src/ui/ve.ui.Context.js b/src/ui/ve.ui.Context.js
index 65f16a6..fb19256 100644
--- a/src/ui/ve.ui.Context.js
+++ b/src/ui/ve.ui.Context.js
@@ -254,7 +254,7 @@
/**
* Get inspector window set.
*
- * @return {OO.ui.WindowManager}
+ * @return {ve.ui.WindowManager}
*/
ve.ui.Context.prototype.getInspectors = function () {
return this.inspectors;
diff --git a/src/ui/ve.ui.DesktopSurface.js b/src/ui/ve.ui.DesktopSurface.js
index ddb6464..2106df9 100644
--- a/src/ui/ve.ui.DesktopSurface.js
+++ b/src/ui/ve.ui.DesktopSurface.js
@@ -37,5 +37,5 @@
* @inheritdoc
*/
ve.ui.DesktopSurface.prototype.createDialogWindowManager = function () {
- return new OO.ui.WindowManager( { factory: ve.ui.windowFactory } );
+ return new ve.ui.WindowManager( { factory: ve.ui.windowFactory } );
};
diff --git a/src/ui/ve.ui.Surface.js b/src/ui/ve.ui.Surface.js
index d2d9253..76f9372 100644
--- a/src/ui/ve.ui.Surface.js
+++ b/src/ui/ve.ui.Surface.js
@@ -216,7 +216,7 @@
* Get dialogs window set.
*
* @method
- * @returns {OO.ui.WindowManager} Dialogs window set
+ * @returns {ve.ui.WindowManager} Dialogs window set
*/
ve.ui.Surface.prototype.getDialogs = function () {
return this.dialogs;
diff --git a/src/ui/widgets/ve.ui.LanguageInputWidget.js
b/src/ui/widgets/ve.ui.LanguageInputWidget.js
index 9d44cd3..a305046 100644
--- a/src/ui/widgets/ve.ui.LanguageInputWidget.js
+++ b/src/ui/widgets/ve.ui.LanguageInputWidget.js
@@ -13,7 +13,7 @@
* @constructor
* @param {Object} [config] Configuration options
* @cfg {boolean} [requireDir] Require directionality to be set (no 'auto'
value)
- * @cfg {OO.ui.WindowManager} [dialogManager] Window manager to launch the
language search dialog in
+ * @cfg {ve.ui.WindowManager} [dialogManager] Window manager to launch the
language search dialog in
*/
ve.ui.LanguageInputWidget = function VeUiLanguageInputWidget( config ) {
// Configuration initialization
@@ -26,7 +26,7 @@
this.lang = null;
this.dir = null;
this.overlay = new ve.ui.Overlay( { classes: ['ve-ui-overlay-global'] }
);
- this.dialogs = config.dialogManager || new OO.ui.WindowManager( {
factory: ve.ui.windowFactory, isolate: true } );
+ this.dialogs = config.dialogManager || new ve.ui.WindowManager( {
factory: ve.ui.windowFactory, isolate: true } );
this.findLanguageButton = new OO.ui.ButtonWidget( {
$: this.$,
classes: [ 've-ui-languageInputWidget-findLanguageButton' ],
--
To view, visit https://gerrit.wikimedia.org/r/175125
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id6660a4b54a496eefa6c79e162570d402f95eab5
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
