Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/175211
Change subject: Emit ce.Surface#position after dm.Surface#documentUpdate
......................................................................
Emit ce.Surface#position after dm.Surface#documentUpdate
Change-Id: I8372fa0eaaef41cf3b6182b756ba94f9711c7205
---
M src/ce/ve.ce.Surface.js
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/11/175211/1
diff --git a/src/ce/ve.ce.Surface.js b/src/ce/ve.ce.Surface.js
index 9a442db..9309e8b 100644
--- a/src/ce/ve.ce.Surface.js
+++ b/src/ce/ve.ce.Surface.js
@@ -1942,13 +1942,17 @@
* Handle documentUpdate events on the surface model.
*/
ve.ce.Surface.prototype.onModelDocumentUpdate = function () {
+ var surface = this;
if ( this.contentBranchNodeChanged ) {
// Update the selection state from model
this.onModelSelect( this.surface.getModel().selection );
}
// Update the state of the SurfaceObserver
this.surfaceObserver.pollOnceNoEmit();
- this.emit( 'position' );
+ // Wait for other documentUpdate listeners to run before emitting
+ setTimeout( function () {
+ surface.emit( 'position' );
+ } );
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/175211
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8372fa0eaaef41cf3b6182b756ba94f9711c7205
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits