Katie Horn has uploaded a new change for review.
https://gerrit.wikimedia.org/r/175599
Change subject: Removing language cruft and copypasta in usin tests
......................................................................
Removing language cruft and copypasta in usin tests
Some form laoding tests were asserting that the translations never
changed, and this is no longer userful.
Change-Id: I85e9b60de8fd394f1136e69726d6dc4abd98c6e1
---
M tests/Adapter/GlobalCollect/GlobalCollectFormLoadTest.php
M tests/Adapter/GlobalCollect/GlobalCollectOrphanAdapterTest.php
M tests/Adapter/WorldPay/WorldPayTest.php
3 files changed, 1 insertion(+), 42 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface
refs/changes/99/175599/1
diff --git a/tests/Adapter/GlobalCollect/GlobalCollectFormLoadTest.php
b/tests/Adapter/GlobalCollect/GlobalCollectFormLoadTest.php
index be5fec7..b453c57 100644
--- a/tests/Adapter/GlobalCollect/GlobalCollectFormLoadTest.php
+++ b/tests/Adapter/GlobalCollect/GlobalCollectFormLoadTest.php
@@ -68,10 +68,6 @@
'nodename' => 'input',
'value' => 'Nom',
),
- 'informationsharing' => array (
- 'nodename' => 'p',
- 'innerhtml' => "En faisant ce don, vous
acceptez notre politique de confidentialité en matière de donation ainsi que de
partager vos données personnelles avec la <a
href=\"https://wikimediafoundation.org/wiki/Special:LandingCheck?basic=true&landing_page=Tax_Deductibility&country=FR&language=fr&uselang=fr\";>Fondation
Wikimédia</a> et ses prestataires de services situés aux Etats-Unis et
ailleurs.",
- ),
'country' => array (
'nodename' => 'select',
'selected' => 'FR',
diff --git a/tests/Adapter/GlobalCollect/GlobalCollectOrphanAdapterTest.php
b/tests/Adapter/GlobalCollect/GlobalCollectOrphanAdapterTest.php
index 233613e..cca04de 100644
--- a/tests/Adapter/GlobalCollect/GlobalCollectOrphanAdapterTest.php
+++ b/tests/Adapter/GlobalCollect/GlobalCollectOrphanAdapterTest.php
@@ -121,39 +121,6 @@
$this->verifyFormOutput( 'TestingGlobalCollectGateway', $init,
$assertNodes, true );
}
- function testGCFormLoad_FR() {
- $init = $this->getDonorTestData( 'FR' );
- unset( $init['order_id'] );
- $init['payment_method'] = 'cc';
- $init['payment_submethod'] = 'visa';
- $init['ffname'] = 'cc-vmaj';
-
- $assertNodes = array (
- 'selected-amount' => array (
- 'nodename' => 'span',
- 'innerhtml' => '€1.55',
- ),
- 'fname' => array (
- 'nodename' => 'input',
- 'value' => 'Prénom',
- ),
- 'lname' => array (
- 'nodename' => 'input',
- 'value' => 'Nom',
- ),
- 'informationsharing' => array (
- 'nodename' => 'p',
- 'innerhtml' => "En faisant ce don, vous
acceptez notre politique de confidentialité en matière de donation ainsi que de
partager vos données personnelles avec la <a
href=\"https://wikimediafoundation.org/wiki/Special:LandingCheck?basic=true&landing_page=Tax_Deductibility&country=FR&language=fr&uselang=fr\";>Fondation
Wikimédia</a> et ses prestataires de services situés aux Etats-Unis et
ailleurs.",
- ),
- 'country' => array (
- 'nodename' => 'select',
- 'selected' => 'FR',
- ),
- );
-
- $this->verifyFormOutput( 'TestingGlobalCollectGateway', $init,
$assertNodes, true );
- }
-
/**
* Tests to make sure that certain error codes returned from GC will
* trigger order cancellation, even if retryable errors also exist.
@@ -168,7 +135,7 @@
$init['order_id'] = '55555';
$init['email'] = '[email protected]';
$gateway->loadDataAndReInit( $init, $useDB = false );
-
+
$gateway->setDummyGatewayResponseCode( $code );
$result = $gateway->do_transaction( 'Confirm_CreditCard' );
$this->assertEquals( 1, count( $gateway->curled ), "Gateway
kept trying even with response code $code! MasterCard could fine us a thousand
bucks for that!" );
diff --git a/tests/Adapter/WorldPay/WorldPayTest.php
b/tests/Adapter/WorldPay/WorldPayTest.php
index 13e40e4..a28a6d0 100644
--- a/tests/Adapter/WorldPay/WorldPayTest.php
+++ b/tests/Adapter/WorldPay/WorldPayTest.php
@@ -182,10 +182,6 @@
'nodename' => 'input',
'value' => 'Nom',
),
- 'informationsharing' => array (
- 'nodename' => 'p',
- 'innerhtml' => "En faisant ce don, vous
acceptez notre politique de confidentialité en matière de donation ainsi que de
partager vos données personnelles avec la <a
href=\"https://wikimediafoundation.org/wiki/Special:LandingCheck?basic=true&landing_page=Tax_Deductibility&country=FR&language=fr&uselang=fr\";>Fondation
Wikimédia</a> et ses prestataires de services situés aux Etats-Unis et
ailleurs.",
- ),
'country' => array (
'nodename' => 'input',
'value' => 'FR',
--
To view, visit https://gerrit.wikimedia.org/r/175599
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I85e9b60de8fd394f1136e69726d6dc4abd98c6e1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Katie Horn <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
