AndyRussG has uploaded a new change for review. https://gerrit.wikimedia.org/r/175606
Change subject: Fix previewing banner on-wiki ...................................................................... Fix previewing banner on-wiki Change-Id: I68933ce42015f61f89cce3fbdcc83b3038607da3 --- M modules/ext.centralNotice.bannerController/bannerController.js 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice refs/changes/06/175606/1 diff --git a/modules/ext.centralNotice.bannerController/bannerController.js b/modules/ext.centralNotice.bannerController/bannerController.js index 60e220e..5918cf2 100644 --- a/modules/ext.centralNotice.bannerController/bannerController.js +++ b/modules/ext.centralNotice.bannerController/bannerController.js @@ -390,10 +390,13 @@ if ( !mw.centralNotice.chooseBannerOnClient ) { mw.centralNotice.storeBucket(); - } else { + } else if ( !mw.centralNotice.data.getVars.banner ) { + // If we are choosing banners on the client, that means we // haven't set the bucket in the impression data. Add it // along with its start and end dates. + // However we won't do this when a banner is being forced via + // the banner URL param. bucket = mw.cnBannerControllerLib.bucketsByCampaign[impressionData.campaign]; impressionData.bucket = bucket.val; impressionData.bucketStart = bucket.start; -- To view, visit https://gerrit.wikimedia.org/r/175606 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I68933ce42015f61f89cce3fbdcc83b3038607da3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CentralNotice Gerrit-Branch: master Gerrit-Owner: AndyRussG <andrew.green...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits