Gergő Tisza has uploaded a new change for review. https://gerrit.wikimedia.org/r/175622
Change subject: Rough logging of metadata panel scrolling ...................................................................... Rough logging of metadata panel scrolling Logs metadata panel open/close by scroll. When the panel is opened via keyboard or the "view terms" button, both a normal and a scroll opening event is logged (same for closing). When the panel is opened in fullscreen mode, neither event is logged. Change-Id: I09092b8b6c20e6fea03b4fe59c811d7b441ca224 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/559 --- M MultimediaViewer.php M resources/mmv/ui/mmv.ui.metadataPanelScroller.js 2 files changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer refs/changes/22/175622/1 diff --git a/MultimediaViewer.php b/MultimediaViewer.php index 7a47510..246ecf0 100644 --- a/MultimediaViewer.php +++ b/MultimediaViewer.php @@ -1051,7 +1051,7 @@ $wgHooks['EventLoggingRegisterSchemas'][] = function( array &$schemas ) { $schemas += array( - 'MediaViewer' => 10536413, + 'MediaViewer' => 10606177, 'MultimediaViewerNetworkPerformance' => 7917896, 'MultimediaViewerDuration' => 10427980, 'MultimediaViewerAttribution' => 9758179, diff --git a/resources/mmv/ui/mmv.ui.metadataPanelScroller.js b/resources/mmv/ui/mmv.ui.metadataPanelScroller.js index 8fa2733..7cd9a8e 100644 --- a/resources/mmv/ui/mmv.ui.metadataPanelScroller.js +++ b/resources/mmv/ui/mmv.ui.metadataPanelScroller.js @@ -222,8 +222,13 @@ if ( panelIsOpen && !this.panelWasOpen ) { // just opened this.$container.trigger( 'mmv-metadata-open' ); + // This will include keyboard- and mouseclick-initiated open events as well, + // since the panel is anomated, which counts as scrolling. + // Filtering these seems too much trouble to be worth it. + mw.mmv.actionLogger.log( 'metadata-scroll-open' ); } else if ( !panelIsOpen && this.panelWasOpen ) { // just closed this.$container.trigger( 'mmv-metadata-close' ); + mw.mmv.actionLogger.log( 'metadata-scroll-close' ); } this.panelWasOpen = panelIsOpen; }; -- To view, visit https://gerrit.wikimedia.org/r/175622 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I09092b8b6c20e6fea03b4fe59c811d7b441ca224 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MultimediaViewer Gerrit-Branch: master Gerrit-Owner: Gergő Tisza <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
