Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/175783
Change subject: QA: allow longer class definition ...................................................................... QA: allow longer class definition class FlowPage is big! With this the mwext-Flow-bundle-rubocop CI test passes. Note there's another rules file in tests/browser/.rubocop_todo.yml, I think we can remove it. Change-Id: I8f3486bc021c8d7e91274545122368af7abde97e --- M .rubocop_todo.yml 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow refs/changes/83/175783/1 diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 8a76932..9e8cca5 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -8,7 +8,8 @@ # Offense count: 1 # Configuration parameters: CountComments. Metrics/ClassLength: - Max: 165 + # TODO reset to 165 after breaking up class FlowPage in features/support/pages/flow_page.rb + Max: 180 # Offense count: 66 # Configuration parameters: AllowURI, URISchemes. -- To view, visit https://gerrit.wikimedia.org/r/175783 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8f3486bc021c8d7e91274545122368af7abde97e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Flow Gerrit-Branch: master Gerrit-Owner: Spage <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
