AndyRussG has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/175786

Change subject: Fix check of banner logged-in status properties
......................................................................

Fix check of banner logged-in status properties

Change-Id: I8036e34f9367b33dd2f2b81bb5be1d117f58a815
---
M modules/ext.centralNotice.bannerController/bannerController.lib.js
1 file changed, 2 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice 
refs/changes/86/175786/1

diff --git a/modules/ext.centralNotice.bannerController/bannerController.lib.js 
b/modules/ext.centralNotice.bannerController/bannerController.lib.js
index 8548f70..84d9e08 100644
--- a/modules/ext.centralNotice.bannerController/bannerController.lib.js
+++ b/modules/ext.centralNotice.bannerController/bannerController.lib.js
@@ -311,12 +311,10 @@
                                        }
 
                                        // Filter for logged-in status
-                                       if ( mw.centralNotice.data.anonymous &&
-                                               ( banner.display_anon != 1 ) ) {
+                                       if ( mw.centralNotice.data.anonymous && 
!banner.display_anon ) {
                                                continue;
                                        }
-                                       if ( !mw.centralNotice.data.anonymous &&
-                                               ( banner.display_account != 1 ) 
) {
+                                       if ( !mw.centralNotice.data.anonymous 
&& !banner.display_account ) {
                                                continue;
                                        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/175786
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8036e34f9367b33dd2f2b81bb5be1d117f58a815
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: AndyRussG <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to