jenkins-bot has submitted this change and it was merged.
Change subject: Stop type hinting against Entity in TermSqlIndex
......................................................................
Stop type hinting against Entity in TermSqlIndex
Change-Id: Iec00a5daa324a9e28bf88053e846ce133a8c04c7
---
M lib/includes/store/sql/TermSqlIndex.php
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Thiemo Mättig (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/includes/store/sql/TermSqlIndex.php
b/lib/includes/store/sql/TermSqlIndex.php
index 2e93be4..1ec6880 100644
--- a/lib/includes/store/sql/TermSqlIndex.php
+++ b/lib/includes/store/sql/TermSqlIndex.php
@@ -7,7 +7,6 @@
use InvalidArgumentException;
use Iterator;
use MWException;
-use Wikibase\DataModel\Entity\Entity;
use Wikibase\DataModel\Entity\EntityDocument;
use Wikibase\DataModel\Entity\EntityId;
use Wikibase\DataModel\Entity\Item;
@@ -251,13 +250,13 @@
*
* @since 0.5
*
- * @param Entity $entity
+ * @param EntityDocument $entity
* @param Term[] $terms
* @param DatabaseBase $dbw
*
* @return boolean Success indicator
*/
- public function deleteTermsInternal( Entity $entity, $terms,
DatabaseBase $dbw ) {
+ public function deleteTermsInternal( EntityDocument $entity, $terms,
DatabaseBase $dbw ) {
wfProfileIn( __METHOD__ );
//TODO: Make getTermsOfEntity() collect term_row_id values, so
we can use them here.
--
To view, visit https://gerrit.wikimedia.org/r/175747
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec00a5daa324a9e28bf88053e846ce133a8c04c7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
