Catrope has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/175893

Change subject: Work around broken BooketLayout#focus method in OOUI for now
......................................................................

Work around broken BooketLayout#focus method in OOUI for now

Change-Id: I1750951487fc7a8e1fcb5fff5dea6ee9a2547cf1
---
M modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/93/175893/1

diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js 
b/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
index 7226f52..385bfd1 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
@@ -495,7 +495,8 @@
 ve.ui.MWTemplateDialog.prototype.getReadyProcess = function ( data ) {
        return ve.ui.MWTemplateDialog.super.prototype.getReadyProcess.call( 
this, data )
                .next( function () {
-                       this.bookletLayout.focus();
+                       // TODO: Uncomment this when OOUI is updated so 
.focus() on an empty booklet doesn't crash
+                       //this.bookletLayout.focus();
                }, this );
 };
 

-- 
To view, visit https://gerrit.wikimedia.org/r/175893
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1750951487fc7a8e1fcb5fff5dea6ee9a2547cf1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <roan.katt...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to