Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176021
Change subject: Do not show 'sha1' in prop=revisions when it has a null value
on db
......................................................................
Do not show 'sha1' in prop=revisions when it has a null value on db
list=recentchanges acts like this
Change-Id: I203e924ec65bcd732a551d837bb0aeffbeabcb59
---
M includes/api/ApiQueryRevisionsBase.php
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/21/176021/1
diff --git a/includes/api/ApiQueryRevisionsBase.php
b/includes/api/ApiQueryRevisionsBase.php
index 4d75a20..912935e 100644
--- a/includes/api/ApiQueryRevisionsBase.php
+++ b/includes/api/ApiQueryRevisionsBase.php
@@ -204,13 +204,13 @@
}
}
- if ( $this->fld_sha1 ) {
+ if ( $this->fld_sha1 && $revision->getSha1() !== null ) {
if ( $revision->isDeleted( Revision::DELETED_TEXT ) ) {
$vals['sha1hidden'] = '';
$anyHidden = true;
}
if ( $revision->userCan( Revision::DELETED_TEXT, $user
) ) {
- if ( $revision->getSha1() != '' ) {
+ if ( $revision->getSha1() !== '' ) {
$vals['sha1'] = wfBaseConvert(
$revision->getSha1(), 36, 16, 40 );
} else {
$vals['sha1'] = '';
--
To view, visit https://gerrit.wikimedia.org/r/176021
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I203e924ec65bcd732a551d837bb0aeffbeabcb59
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
