Awight has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176037
Change subject: remote unused stylepath cruft
......................................................................
remote unused stylepath cruft
We're using ResourceLoader now. There are many reasons we want to do that,
most importantly, transparent RTL conversion.
Change-Id: Ie3e234f9d1d218655d46efd945d3996afacaf9d2
---
M gateway_forms/Form.php
D gateway_forms/css/Form.css
2 files changed, 0 insertions(+), 39 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface
refs/changes/37/176037/1
diff --git a/gateway_forms/Form.php b/gateway_forms/Form.php
index a5b2770..b70dbb1 100644
--- a/gateway_forms/Form.php
+++ b/gateway_forms/Form.php
@@ -77,20 +77,6 @@
$this->form_errors = array_merge(
DataValidator::getEmptyErrorArray(), $gateway_errors );
$this->paypal = $wgRequest->getBool( 'paypal', false );
- /**
- * add form-specific css - the path can be set in child classes
- * using $this->setStylePath, which should be called before
- * calling parent::__construct()
- *
- * @TODO ditch this and start using ResourceLoader. Perhaps do
something
- * similar to how resources are getting loaded in
TwoStepTwoColumn and
- * its children.
- */
- if ( !strlen( $this->getStylePath() ) ) {
- $this->setStylePath();
- }
- $wgOut->addExtensionStyle( $this->getStylePath() );
-
// This method should be overridden in the child class
$this->init();
}
@@ -101,31 +87,6 @@
* overridden where necessary in child classes.
*/
protected function init() {
- }
-
- /**
- * Set the path to the CSS file for the form
- *
- * This should be a full path, perhaps taking advantage of
$wgScriptPath.
- * If you do not pass the path to the method, the style path will
default
- * to the default css in css/Form.css
- * @param string $style_path
- */
- public function setStylePath( $style_path = null ) {
- global $wgExtensionAssetsPath;
- if ( !$style_path ) {
- // load the default form CSS if the style path not
explicitly set
- $style_path = $wgExtensionAssetsPath .
'/DonationInterface/gateway_forms/css/Form.css';
- }
- $this->style_path = $style_path;
- }
-
- /**
- * Get the path to CSS
- * @return String
- */
- public function getStylePath() {
- return $this->style_path;
}
/**
diff --git a/gateway_forms/css/Form.css b/gateway_forms/css/Form.css
deleted file mode 100644
index e69de29..0000000
--- a/gateway_forms/css/Form.css
+++ /dev/null
--
To view, visit https://gerrit.wikimedia.org/r/176037
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3e234f9d1d218655d46efd945d3996afacaf9d2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Awight <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
