Adrian Lang has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176229
Change subject: Move ClaimHtmlGenerator to Wikibase\Repo\View
......................................................................
Move ClaimHtmlGenerator to Wikibase\Repo\View
Change-Id: Ibc725c5ecebf1e321c934fc548b9ad91138ffd7a
---
R repo/includes/View/ClaimHtmlGenerator.php
M repo/includes/View/ClaimsView.php
M repo/includes/View/EntityViewFactory.php
R repo/tests/phpunit/includes/View/ClaimHtmlGeneratorTest.php
M repo/tests/phpunit/includes/View/ClaimsViewTest.php
5 files changed, 4 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/29/176229/1
diff --git a/repo/includes/ClaimHtmlGenerator.php
b/repo/includes/View/ClaimHtmlGenerator.php
similarity index 98%
rename from repo/includes/ClaimHtmlGenerator.php
rename to repo/includes/View/ClaimHtmlGenerator.php
index c5b127c..141ba3e 100644
--- a/repo/includes/ClaimHtmlGenerator.php
+++ b/repo/includes/View/ClaimHtmlGenerator.php
@@ -1,6 +1,6 @@
<?php
-namespace Wikibase;
+namespace Wikibase\Repo\View;
use Wikibase\DataModel\ByPropertyIdArray;
use Wikibase\DataModel\Claim\Claim;
@@ -9,7 +9,6 @@
use Wikibase\DataModel\Statement\Statement;
use Wikibase\Lib\Serializers\ClaimSerializer;
use Wikibase\Lib\Store\EntityTitleLookup;
-use Wikibase\Repo\View\SnakHtmlGenerator;
/**
* Base class for generating the HTML for a Claim in Entity View.
diff --git a/repo/includes/View/ClaimsView.php
b/repo/includes/View/ClaimsView.php
index b0f7153..ccd3c56 100644
--- a/repo/includes/View/ClaimsView.php
+++ b/repo/includes/View/ClaimsView.php
@@ -3,7 +3,6 @@
namespace Wikibase\Repo\View;
use Linker;
-use Wikibase\ClaimHtmlGenerator;
use Wikibase\DataModel\Claim\Claim;
use Wikibase\DataModel\Entity\EntityId;
use Wikibase\DataModel\Entity\Property;
diff --git a/repo/includes/View/EntityViewFactory.php
b/repo/includes/View/EntityViewFactory.php
index 8c2afad..5a047c2 100644
--- a/repo/includes/View/EntityViewFactory.php
+++ b/repo/includes/View/EntityViewFactory.php
@@ -6,7 +6,6 @@
use Language;
use ValueFormatters\FormatterOptions;
use ValueFormatters\ValueFormatter;
-use Wikibase\ClaimHtmlGenerator;
use Wikibase\EntityView;
use Wikibase\ItemView;
use Wikibase\LanguageFallbackChain;
diff --git a/repo/tests/phpunit/includes/ClaimHtmlGeneratorTest.php
b/repo/tests/phpunit/includes/View/ClaimHtmlGeneratorTest.php
similarity index 98%
rename from repo/tests/phpunit/includes/ClaimHtmlGeneratorTest.php
rename to repo/tests/phpunit/includes/View/ClaimHtmlGeneratorTest.php
index eddb0ee..37fea2f 100644
--- a/repo/tests/phpunit/includes/ClaimHtmlGeneratorTest.php
+++ b/repo/tests/phpunit/includes/View/ClaimHtmlGeneratorTest.php
@@ -4,7 +4,6 @@
use DataValues\StringValue;
use Title;
-use Wikibase\ClaimHtmlGenerator;
use Wikibase\DataModel\Claim\Claim;
use Wikibase\DataModel\Entity\EntityId;
use Wikibase\DataModel\Reference;
@@ -16,6 +15,7 @@
use Wikibase\Lib\DispatchingSnakFormatter;
use Wikibase\Lib\SnakFormatter;
use Wikibase\Lib\Store\EntityTitleLookup;
+use Wikibase\Repo\View\ClaimHtmlGenerator;
use Wikibase\Repo\View\SnakHtmlGenerator;
/**
diff --git a/repo/tests/phpunit/includes/View/ClaimsViewTest.php
b/repo/tests/phpunit/includes/View/ClaimsViewTest.php
index da3ac43..60a3343 100644
--- a/repo/tests/phpunit/includes/View/ClaimsViewTest.php
+++ b/repo/tests/phpunit/includes/View/ClaimsViewTest.php
@@ -5,7 +5,6 @@
use DataValues\StringValue;
use TestUser;
use Title;
-use Wikibase\ClaimHtmlGenerator;
use Wikibase\DataModel\Claim\Claim;
use Wikibase\DataModel\Entity\EntityId;
use Wikibase\DataModel\Entity\EntityIdValue;
@@ -17,6 +16,7 @@
use Wikibase\DataModel\Snak\PropertyValueSnak;
use Wikibase\DataModel\Snak\Snak;
use Wikibase\Lib\Store\EntityTitleLookup;
+use Wikibase\Repo\View\ClaimHtmlGenerator;
use Wikibase\Repo\View\ClaimsView;
use Wikibase\Repo\View\SectionEditLinkGenerator;
use Wikibase\Repo\WikibaseRepo;
@@ -160,7 +160,7 @@
* @return ClaimHtmlGenerator
*/
private function getClaimHtmlGeneratorMock() {
- $claimHtmlGenerator = $this->getMockBuilder(
'Wikibase\ClaimHtmlGenerator' )
+ $claimHtmlGenerator = $this->getMockBuilder(
'Wikibase\Repo\View\ClaimHtmlGenerator' )
->disableOriginalConstructor()
->getMock();
--
To view, visit https://gerrit.wikimedia.org/r/176229
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc725c5ecebf1e321c934fc548b9ad91138ffd7a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
