Mglaser has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/176244

Change subject: Cache invalidation on insertShout
......................................................................

Cache invalidation on insertShout

Cache key now doesn't include the number of messages. This is a global
setting and does not change per user. And it is not available in all
contexts, e.g. when archiving shouts. So the determining factor for the
cache is now solely the article id. This fixes an issue, where new shouts
would not be displayed for a while.

Change-Id: I1f6e1282c0a6853082c21a42eb6ca8eaca8c6b10
---
M ShoutBox/ShoutBox.class.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceExtensions 
refs/changes/44/176244/1

diff --git a/ShoutBox/ShoutBox.class.php b/ShoutBox/ShoutBox.class.php
index ad53595..c86038f 100644
--- a/ShoutBox/ShoutBox.class.php
+++ b/ShoutBox/ShoutBox.class.php
@@ -267,7 +267,7 @@
                if ( $iArticleId <= 0 )
                        return true;
 
-               $sKey = BsCacheHelper::getCacheKey( 'BlueSpice', 'ShoutBox', 
$iArticleId, $iLimit );
+               $sKey = BsCacheHelper::getCacheKey( 'BlueSpice', 'ShoutBox', 
$iArticleId );
                $aData = BsCacheHelper::get( $sKey );
 
                if ( $aData !== false ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/176244
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1f6e1282c0a6853082c21a42eb6ca8eaca8c6b10
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: master
Gerrit-Owner: Mglaser <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to