Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176296
Change subject: Expand error message when parser tests found no hook
......................................................................
Expand error message when parser tests found no hook
The existing message is hard to understand and does not mention, that
this is a problem in the parser test itself and not with phpunit.
Before:
1) Warning
The data provider specified for ParserTest_<file>::testParserTest is
invalid.
Problem running hook
After:
1) Warning
The data provider specified for ParserTest_<file>::testParser
Problem running requested parser hook from the test file
Change-Id: I0b4225cc9ab95e8dd048515315c789113dacf39e
---
M tests/testHelpers.inc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/96/176296/1
diff --git a/tests/testHelpers.inc b/tests/testHelpers.inc
index b5fc800..f1e8c44 100644
--- a/tests/testHelpers.inc
+++ b/tests/testHelpers.inc
@@ -471,7 +471,7 @@
$hooksResult = $this->delayedParserTest->unleash(
$this->parserTest );
if ( !$hooksResult ) {
# Some hook reported an issue. Abort.
- throw new MWException( "Problem running hook" );
+ throw new MWException( "Problem running requested
parser hook from the test file" );
}
$this->test = array(
--
To view, visit https://gerrit.wikimedia.org/r/176296
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b4225cc9ab95e8dd048515315c789113dacf39e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
