jenkins-bot has submitted this change and it was merged.
Change subject: Replace deprecated mw.util.updateTooltipAccessKeys
......................................................................
Replace deprecated mw.util.updateTooltipAccessKeys
Change-Id: Iea57ff0bb23c72bf70070a1110632ea86a132fe4
---
M frontend/FlaggedRevsUI.setup.php
M frontend/modules/ext.flaggedRevs.advanced.js
2 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Krinkle: Looks good to me, but someone else must approve
TheDJ: Looks good to me, approved
jenkins-bot: Verified
diff --git a/frontend/FlaggedRevsUI.setup.php b/frontend/FlaggedRevsUI.setup.php
index e8e862a..da33d7f 100644
--- a/frontend/FlaggedRevsUI.setup.php
+++ b/frontend/FlaggedRevsUI.setup.php
@@ -155,7 +155,7 @@
'revreview-log-toggle-show',
'revreview-log-toggle-hide',
'revreview-log-details-show',
'revreview-log-details-hide'
),
- 'dependencies' => array( 'mediawiki.util' ),
+ 'dependencies' => array( 'jquery.accessKeyLabel' ),
'localBasePath' => $localModulePath,
'remoteExtPath' => $remoteModulePath,
);
@@ -163,7 +163,7 @@
'scripts' => array( 'ext.flaggedRevs.review.js' ),
'styles' => array( 'ext.flaggedRevs.review.css'
),
'messages' => array(
- 'savearticle', 'tooltip-save', 'accesskey-save',
+ 'savearticle', 'tooltip-save',
'revreview-submitedit',
'revreview-submitedit-title',
'revreview-submit-review',
'revreview-submit-unreview',
'revreview-submit-reviewed',
'revreview-submit-unreviewed',
diff --git a/frontend/modules/ext.flaggedRevs.advanced.js
b/frontend/modules/ext.flaggedRevs.advanced.js
index 4210041..15faede 100644
--- a/frontend/modules/ext.flaggedRevs.advanced.js
+++ b/frontend/modules/ext.flaggedRevs.advanced.js
@@ -191,18 +191,18 @@
$save
.val( mw.msg( 'savearticle' ) )
.attr( 'title',
- mw.msg( 'tooltip-save' ) + ' ['
+ mw.msg( 'accesskey-save' ) + ']'
+ mw.msg( 'tooltip-save' )
);
// Submit for review
} else {
$save
.val( mw.msg( 'revreview-submitedit' ) )
.attr( 'title',
- mw.msg(
'revreview-submitedit-title' ) + ' [' + mw.msg( 'accesskey-save' ) + ']'
+ mw.msg(
'revreview-submitedit-title' )
);
}
+ $save.updateTooltipAccessKeys();
}
- mw.util.updateTooltipAccessKeys( [ $save ] ); // update
accesskey in save.title
}
};
--
To view, visit https://gerrit.wikimedia.org/r/138890
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea57ff0bb23c72bf70070a1110632ea86a132fe4
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: Fomafix
Gerrit-Reviewer: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: TheDJ <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
