Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176736
Change subject: Update the Search funnel to have a session ID.
......................................................................
Update the Search funnel to have a session ID.
Change-Id: I406fba2bd6f0f593a40343be09cd551be19b25d8
---
M wikipedia/src/main/java/org/wikipedia/analytics/SearchFunnel.java
M wikipedia/src/main/java/org/wikipedia/search/SearchArticlesFragment.java
2 files changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/36/176736/1
diff --git a/wikipedia/src/main/java/org/wikipedia/analytics/SearchFunnel.java
b/wikipedia/src/main/java/org/wikipedia/analytics/SearchFunnel.java
index 535b939..17b2c2e 100644
--- a/wikipedia/src/main/java/org/wikipedia/analytics/SearchFunnel.java
+++ b/wikipedia/src/main/java/org/wikipedia/analytics/SearchFunnel.java
@@ -3,17 +3,20 @@
import org.wikipedia.WikipediaApp;
import org.json.JSONException;
import org.json.JSONObject;
+import java.util.UUID;
public class SearchFunnel extends Funnel {
private static final String SCHEMA_NAME = "MobileWikiAppSearch";
- private static final int REVISION = 10633564;
+ private static final int REVISION = 10641988;
+ private final String searchSessionToken;
private final String appInstallID;
public SearchFunnel(WikipediaApp app) {
super(app, SCHEMA_NAME, REVISION);
//Retrieve this app installation's unique ID, used to record unique
users of features
appInstallID = app.getAppInstallID();
+ searchSessionToken = UUID.randomUUID().toString();
}
protected void log(Object... params) {
@@ -40,6 +43,7 @@
protected JSONObject preprocessData(JSONObject eventData) {
try {
eventData.put("appInstallID", appInstallID);
+ eventData.put("searchSessionToken", searchSessionToken);
} catch (JSONException e) {
// This isn't happening
throw new RuntimeException(e);
diff --git
a/wikipedia/src/main/java/org/wikipedia/search/SearchArticlesFragment.java
b/wikipedia/src/main/java/org/wikipedia/search/SearchArticlesFragment.java
index a9296c4..5b99b3d 100644
--- a/wikipedia/src/main/java/org/wikipedia/search/SearchArticlesFragment.java
+++ b/wikipedia/src/main/java/org/wikipedia/search/SearchArticlesFragment.java
@@ -305,6 +305,8 @@
* Activate the Search fragment.
*/
public void openSearch() {
+ // create a new funnel every time Search is opened, to get a new
session ID
+ funnel = new SearchFunnel(WikipediaApp.getInstance());
funnel.searchStart();
isSearchActive = true;
// invalidate our activity's ActionBar, so that we'll have a chance to
inject our
--
To view, visit https://gerrit.wikimedia.org/r/176736
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I406fba2bd6f0f593a40343be09cd551be19b25d8
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
