jenkins-bot has submitted this change and it was merged. Change subject: QA: remove pageactions_logged_in.feature and unique steps ......................................................................
QA: remove pageactions_logged_in.feature and unique steps This test is made redundant by the editor_wikitext_saving.feature and by watchstar.feature, which cover the same functions in more depth Change-Id: I97350dff133664a188983528e96b064eca9f6b0f --- D tests/browser/features/pageactions_logged_in.feature M tests/browser/features/step_definitions/common_article_steps.rb M tests/browser/features/step_definitions/pageactions_steps.rb 3 files changed, 0 insertions(+), 23 deletions(-) Approvals: Cmcmahon: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/browser/features/pageactions_logged_in.feature b/tests/browser/features/pageactions_logged_in.feature deleted file mode 100644 index 3526042..0000000 --- a/tests/browser/features/pageactions_logged_in.feature +++ /dev/null @@ -1,14 +0,0 @@ -@chrome @en.m.wikipedia.beta.wmflabs.org @firefox @login @test2.m.wikipedia.org @vagrant -Feature: Page actions menu when logged in - - Background: - Given I am logged into the mobile website - And I am at a random page - - Scenario: I can see the edit button - Then I should see the edit icon - - Scenario: I can add the page to my watchlist - When I click on watchlist icon - # Note could be watched or unwatched so do not check message - Then I see a toast notification diff --git a/tests/browser/features/step_definitions/common_article_steps.rb b/tests/browser/features/step_definitions/common_article_steps.rb index 753b907..841df0b 100644 --- a/tests/browser/features/step_definitions/common_article_steps.rb +++ b/tests/browser/features/step_definitions/common_article_steps.rb @@ -41,7 +41,6 @@ on(ArticlePage).watch_link_element.when_present.click end -# Toast notifications Then(/^I see a toast notification$/) do on(ArticlePage).toast_element.when_present.should be_visible end @@ -78,10 +77,6 @@ # Watch star Then(/^I see the watch star$/) do on(ArticlePage).watch_link_element.should be_visible -end - -Then /^I should see the edit icon$/ do - on(ArticlePage).edit_button_holder_element.when_present.should be_visible end Then(/^I should see the error box message "(.+)"$/) do |error_message| diff --git a/tests/browser/features/step_definitions/pageactions_steps.rb b/tests/browser/features/step_definitions/pageactions_steps.rb index 19a41eb..1fe3ecb 100644 --- a/tests/browser/features/step_definitions/pageactions_steps.rb +++ b/tests/browser/features/step_definitions/pageactions_steps.rb @@ -1,7 +1,3 @@ -When /^I click on watchlist icon$/ do - on(ArticlePage).watch_link_element.when_present.click -end - Then(/^there is not an upload an image to this page button$/) do on(ArticlePage).upload_button_element.should_not exist end -- To view, visit https://gerrit.wikimedia.org/r/176707 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97350dff133664a188983528e96b064eca9f6b0f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Cmcmahon <[email protected]> Gerrit-Reviewer: Awjrichards <[email protected]> Gerrit-Reviewer: Cmcmahon <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
