Cmcmahon has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176820
Change subject: QA: update pointless test for RSpec3
......................................................................
QA: update pointless test for RSpec3
We no longer allow uploads via the MF UI. We likely never will
again.
This test does not run and likely won't again. Updating the
syntax so it isn't obnoxious when looking through the repo.
Change-Id: Ib73676be691dda7cc2dc9a65ebf3bfd353906987
---
M tests/browser/features/special_uploads.feature
M tests/browser/features/step_definitions/common_article_steps.rb
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/20/176820/1
diff --git a/tests/browser/features/special_uploads.feature
b/tests/browser/features/special_uploads.feature
index 3b9de2f..7c49826 100644
--- a/tests/browser/features/special_uploads.feature
+++ b/tests/browser/features/special_uploads.feature
@@ -25,7 +25,7 @@
And I click on "Uploads" in the main navigation menu
And I can see the uploads interface
When upload bogus file BADFILE.tgz
- Then I see a toast error
+ Then I should see a toast error
Scenario: Upload image file
Given I am logged into the mobile website
diff --git a/tests/browser/features/step_definitions/common_article_steps.rb
b/tests/browser/features/step_definitions/common_article_steps.rb
index b60b628..ede4782 100644
--- a/tests/browser/features/step_definitions/common_article_steps.rb
+++ b/tests/browser/features/step_definitions/common_article_steps.rb
@@ -45,8 +45,8 @@
expect(on(ArticlePage).toast_element.when_present).to be_visible
end
-Then(/^I see a toast error$/) do
- on(ArticlePage).toast_element.when_present.class_name.should match "error"
+Then(/^I should see a toast error$/) do
+ expect(on(ArticlePage).toast_element.when_present.class_name).to match
"error"
end
Then /^the watch star is selected$/ do
--
To view, visit https://gerrit.wikimedia.org/r/176820
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib73676be691dda7cc2dc9a65ebf3bfd353906987
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
