Demon has submitted this change and it was merged. Change subject: (Bug 41574) Supply Title object to Revision if possible. ......................................................................
(Bug 41574) Supply Title object to Revision if possible. The Revision object needs the Title to determine the default content model. Providing the Title explicitely wherever possible avoids an extra database lookup. Most importanlty, this fixes fatal errors that ocurr when the database lookup fails due to slave lag or transaction state. Change-Id: I516e82f7a893b274c513b128b8a46db491160b55 --- M includes/ChangesList.php M includes/Import.php M includes/Revision.php M includes/Title.php M includes/WikiPage.php M includes/specials/SpecialDeletedContributions.php M includes/specials/SpecialMergeHistory.php M tests/phpunit/includes/WikiPageTest.php 8 files changed, 29 insertions(+), 17 deletions(-) Approvals: Demon: Looks good to me, approved Reedy: Looks good to me, but someone else must approve jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/31224 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I516e82f7a893b274c513b128b8a46db491160b55 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler <[email protected]> Gerrit-Reviewer: Aaron Schulz <[email protected]> Gerrit-Reviewer: Aude <[email protected]> Gerrit-Reviewer: Demon <[email protected]> Gerrit-Reviewer: Hashar <[email protected]> Gerrit-Reviewer: Reedy <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
