Phuedx has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176945
Change subject: Enable WikiGrok A/B test using wgMFEnableWikiGrok
......................................................................
Enable WikiGrok A/B test using wgMFEnableWikiGrok
* Sunset wgMFWikiGrokAbTest{Start,End}Date configuration variables
* Still use WikiGrokAbTest#isEnabled to determine if the A/B test is
enabled
Change-Id: I3ec0190a34c1ae70e6becee904abdebde80ee038
---
M javascripts/modules/wikigrok/WikiGrokAbTest.js
M tests/qunit/modules/wikigrok/test_WikiGrokAbTest.js
2 files changed, 9 insertions(+), 37 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/45/176945/1
diff --git a/javascripts/modules/wikigrok/WikiGrokAbTest.js
b/javascripts/modules/wikigrok/WikiGrokAbTest.js
index 0461149..486bba4 100644
--- a/javascripts/modules/wikigrok/WikiGrokAbTest.js
+++ b/javascripts/modules/wikigrok/WikiGrokAbTest.js
@@ -13,15 +13,10 @@
/**
* Initialises a new instance of the WikiGrokAbTest
class.
*
- * @param {Number} startDate The date the test starts,
specified as a Unix
- * timestamp
- * @param {Number} endDate The date that the test ends,
specified as a Unix
- * timestamp
+ * @param {Boolean} isEnabled Whether or not the A/B
test is enabled
*/
- initialize: function ( startDate, endDate ) {
- var now = new Date().getTime() / 1000;
-
- this.isEnabled = startDate && endDate && (
startDate <= now && now <= endDate );
+ initialize: function ( isEnabled ) {
+ this.isEnabled = isEnabled;
},
/**
@@ -45,15 +40,7 @@
* @return {WikiGrokAbTest}
*/
WikiGrokAbTest.newFromMwConfig = function () {
- var config = mw.config.get( [
- 'wgMFWikiGrokAbTestStartDate',
- 'wgMFWikiGrokAbTestEndDate'
- ] );
-
- return new WikiGrokAbTest(
- config.wgMFWikiGrokAbTestStartDate,
- config.wgMFWikiGrokAbTestEndDate
- );
+ return new WikiGrokAbTest( mw.config.get( 'wgMFEnabledWikiGrok'
) );
};
M.define( 'WikiGrokAbTest', WikiGrokAbTest );
diff --git a/tests/qunit/modules/wikigrok/test_WikiGrokAbTest.js
b/tests/qunit/modules/wikigrok/test_WikiGrokAbTest.js
index 5946e7e..be5ec0a 100644
--- a/tests/qunit/modules/wikigrok/test_WikiGrokAbTest.js
+++ b/tests/qunit/modules/wikigrok/test_WikiGrokAbTest.js
@@ -2,28 +2,13 @@
var WikiGrokAbTest = M.require( 'WikiGrokAbTest' ),
wikiGrokUser = M.require( 'wikiGrokUser' ),
- now = new Date().getTime() / 1000,
- enabledTest = new WikiGrokAbTest( now - 86400, now + 86400 );
+ enabledTest = new WikiGrokAbTest( true );
- QUnit.module( 'MobileFrontend: modules/wikigrok/WikiGrokAbTest', {
- } );
+ QUnit.module( 'MobileFrontend: modules/wikigrok/WikiGrokAbTest' );
- QUnit.test( 'isEnabled returns false when the experiment isn\'t
enabled', 2, function ( assert ) {
- var dataProvider = [
- [now + 86400, now + 86401], // startDate is in
the future
- [now - 86400, now - 86401], // endDate in the
past
- ],
- test;
-
- $.each( dataProvider, function ( i, data ) {
- test = new WikiGrokAbTest( data[0], data[1] );
-
- assert.strictEqual( test.isEnabled, false );
- } );
- } );
-
- QUnit.test( 'isEnabled returns true when the test is active', 1,
function ( assert ) {
- assert.strictEqual( enabledTest.isEnabled, true );
+ QUnit.test( 'isEnabled simply exposes the isEnabled constructor
parameter', 2, function ( assert ) {
+ assert.strictEqual( new WikiGrokAbTest( false ).isEnabled,
false );
+ assert.strictEqual( new WikiGrokAbTest( true ).isEnabled, true
);
} );
QUnit.test( 'getVersion()', 62, function ( assert ) {
--
To view, visit https://gerrit.wikimedia.org/r/176945
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ec0190a34c1ae70e6becee904abdebde80ee038
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Phuedx <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
