jenkins-bot has submitted this change and it was merged. Change subject: QA: Ignore RuboCop rules per the coding conventions ......................................................................
QA: Ignore RuboCop rules per the coding conventions Ignore Metrics/ClassLength and other rules per our Ruby coding conventions. https://www.mediawiki.org/w/index.php?title=Manual:Coding_conventions/Ruby&oldid=1280750 Change-Id: I8f3486bc021c8d7e91274545122368af7abde97e --- M .rubocop.yml M .rubocop_todo.yml D tests/browser/.rubocop_todo.yml M tests/browser/features/support/pages/flow_page.rb 4 files changed, 28 insertions(+), 140 deletions(-) Approvals: Cmcmahon: Looks good to me, approved Spage: Looks good to me, approved jenkins-bot: Verified diff --git a/.rubocop.yml b/.rubocop.yml index 288c556..6fc09c7 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,6 +1,33 @@ inherit_from: .rubocop_todo.yml +# See discussion of rules at +# https://www.mediawiki.org/wiki/Manual:Coding_conventions/Ruby + +Metrics/AbcSize: + Enabled: false + +Metrics/ClassLength: + Enabled: false + +Metrics/CyclomaticComplexity: + Enabled: false + +Metrics/MethodLength: + Enabled: false + +Metrics/ParameterLists: + Enabled: false + +Metrics/PerceivedComplexity: + Enabled: false + +Style/Alias: + Enabled: false + # rubocop fix lifted from CirrusSearch/.rubocop.yml Style/LeadingCommentSpace: Exclude: - Gemfile # RVM doesn't recognise spaces after the #s + +Style/SignalException: + Enabled: false diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 8a76932..8e5ff3f 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -5,11 +5,6 @@ # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 1 -# Configuration parameters: CountComments. -Metrics/ClassLength: - Max: 165 - # Offense count: 66 # Configuration parameters: AllowURI, URISchemes. Metrics/LineLength: diff --git a/tests/browser/.rubocop_todo.yml b/tests/browser/.rubocop_todo.yml deleted file mode 100644 index 34b0b3e..0000000 --- a/tests/browser/.rubocop_todo.yml +++ /dev/null @@ -1,135 +0,0 @@ -# This configuration was generated by `rubocop --auto-gen-config` -# on 2014-11-07 11:05:30 -0700 using RuboCop version 0.27.0. -# The point is for the user to remove these configuration records -# one by one as the offenses are removed from the code base. -# Note that changes in the inspected code, or installation of new -# versions of RuboCop, may require this file to be generated again. - -# Offense count: 1 -# Configuration parameters: CountComments. -Metrics/ClassLength: - Max: 165 - -# Offense count: 66 -# Configuration parameters: AllowURI, URISchemes. -Metrics/LineLength: - Max: 224 - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/BracesAroundHashParameters: - Enabled: false - -# Offense count: 1 -# Configuration parameters: Keywords. -Style/CommentAnnotation: - Enabled: false - -# Offense count: 5 -Style/Documentation: - Enabled: false - -# Offense count: 1 -# Cop supports --auto-correct. -Style/EmptyLines: - Enabled: false - -# Offense count: 1 -# Configuration parameters: AllowedVariables. -Style/GlobalVars: - Enabled: false - -# Offense count: 4 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/HashSyntax: - Enabled: false - -# Offense count: 3 -# Cop supports --auto-correct. -# Configuration parameters: Width. -Style/IndentationWidth: - Enabled: false - -# Offense count: 1 -# Cop supports --auto-correct. -Style/MethodCallParentheses: - Enabled: false - -# Offense count: 2 -# Cop supports --auto-correct. -Style/MultilineIfThen: - Enabled: false - -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: AllowSafeAssignment. -Style/ParenthesesAroundCondition: - Enabled: false - -# Offense count: 3 -# Cop supports --auto-correct. -# Configuration parameters: AllowAsExpressionSeparator. -Style/Semicolon: - Enabled: false - -# Offense count: 5 -# Cop supports --auto-correct. -Style/SpaceAfterColon: - Enabled: false - -# Offense count: 1 -# Cop supports --auto-correct. -Style/SpaceAroundOperators: - Enabled: false - -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/SpaceBeforeBlockBraces: - Enabled: false - -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters. -Style/SpaceInsideBlockBraces: - Enabled: false - -# Offense count: 6 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyleForEmptyBraces, SupportedStyles. -Style/SpaceInsideHashLiteralBraces: - EnforcedStyle: no_space - -# Offense count: 21 -# Cop supports --auto-correct. -Style/SpaceInsideParens: - Enabled: false - -# Offense count: 106 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/StringLiterals: - Enabled: false - -# Offense count: 2 -# Cop supports --auto-correct. -Style/Tab: - Enabled: false - -# Offense count: 6 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/TrailingBlankLines: - Enabled: false - -# Offense count: 2 -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/VariableName: - Enabled: false - -# Offense count: 1 -# Cop supports --auto-correct. -Style/WhileUntilDo: - Enabled: false diff --git a/tests/browser/features/support/pages/flow_page.rb b/tests/browser/features/support/pages/flow_page.rb index 5b08010..3031851 100644 --- a/tests/browser/features/support/pages/flow_page.rb +++ b/tests/browser/features/support/pages/flow_page.rb @@ -2,6 +2,7 @@ include PageObject a(:logout, css: "#pt-logout a") end + class FlowPage < WikiPage include URL # MEDIAWIKI_URL must have this in $wgFlowOccupyPages array or $wgFlowOccupyNamespaces. -- To view, visit https://gerrit.wikimedia.org/r/175783 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f3486bc021c8d7e91274545122368af7abde97e Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/Flow Gerrit-Branch: master Gerrit-Owner: Spage <[email protected]> Gerrit-Reviewer: Cmcmahon <[email protected]> Gerrit-Reviewer: Dduvall <[email protected]> Gerrit-Reviewer: SG <[email protected]> Gerrit-Reviewer: Spage <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
