jenkins-bot has submitted this change and it was merged. Change subject: QA: update one assertion for RSpec3 syntax ......................................................................
QA: update one assertion for RSpec3 syntax Will return to get the FIXME when I figure out why this test does not make a redlink properly Change-Id: I629bc984c6de9ea28c4d6494d18f63c2db3b2ec1 --- M tests/browser/features/step_definitions/common_steps.rb 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Cmcmahon: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/browser/features/step_definitions/common_steps.rb b/tests/browser/features/step_definitions/common_steps.rb index 33c4c46..2904323 100644 --- a/tests/browser/features/step_definitions/common_steps.rb +++ b/tests/browser/features/step_definitions/common_steps.rb @@ -101,5 +101,5 @@ Then(/^there is a red link with text "(.+)"$/) do |text| # FIXME: Switch to link_element when red links move to stable - on(ArticlePage).content_wrapper_element.span_element(text: text).when_present(10).should be_visible + expect(on(ArticlePage).content_wrapper_element.span_element(text: text).when_present(10)).to be_visible end -- To view, visit https://gerrit.wikimedia.org/r/177071 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I629bc984c6de9ea28c4d6494d18f63c2db3b2ec1 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Cmcmahon <[email protected]> Gerrit-Reviewer: Awjrichards <[email protected]> Gerrit-Reviewer: Cmcmahon <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
