Krinkle has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/177128

Change subject: gerrit: Don't match Phabricator identifiers within urls
......................................................................

gerrit: Don't match Phabricator identifiers within urls

Sample

* T123
* https://example.org/T123
* Foo bar, T123. (T123)

Bug: T76537
Change-Id: Ib66d7d16cce54cc7962db2f15770f0b4493907ef
---
M modules/gerrit/templates/gerrit.config.erb
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/28/177128/1

diff --git a/modules/gerrit/templates/gerrit.config.erb 
b/modules/gerrit/templates/gerrit.config.erb
index 9162e06..fb071be 100644
--- a/modules/gerrit/templates/gerrit.config.erb
+++ b/modules/gerrit/templates/gerrit.config.erb
@@ -98,8 +98,8 @@
     match = "<li>([^ ]+) (<a 
href=\"https://integration\\.wikimedia\\.org/ci/[a-zA-Z0-9/_.-]+\"; 
target=\"_blank\">)[^<]+</a> : ([a-zA-Z_]+)([^<]*)</li>"
     html  = "<li class=\"ci_comment_test\"><span 
class=\"ci_comment_test_name\">$2$1</a></span> <span 
class=\"ci_comment_test_result\"><span 
class=\"ci_result_$3\">$3</span>$4</span></li>"
 [commentlink "its-phabricator"]
-    match =  "\\bT(\\d+)\\b"
-    link = https://phabricator.wikimedia.org/T$1
+    match =  (^|\\s|[:,!?\\(\\[\\{])T(\\d+)\\b
+    html = "$1<a href=\"https://phabricator.wikimedia.org/T$2\";>$2</a>"
 [mimetype "application/javascript"]
     safe = true
 [mimetype "application/x-php"]

-- 
To view, visit https://gerrit.wikimedia.org/r/177128
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib66d7d16cce54cc7962db2f15770f0b4493907ef
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Krinkle <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to