Hello Ottomata,

I'd like you to do a code review.  Please visit

    https://gerrit.wikimedia.org/r/177224

to review the following change.

Change subject: Ignore traffic from cache-local SSL terminators
......................................................................

Ignore traffic from cache-local SSL terminators

Webstatscollector's C implementation also ignores traffic from
  10.20.0.0/24
  10.64.0.0/24
  10.64.32.0/24
since Ic6e1f8e6f58091b2274a3ab45ddfe38bc9489591.

In order to make them agree again, we also ignore traffic from those
nets.

Bug: T76390
Change-Id: I3ef0ef2a6bdd16c7f00f56216df47b18df2aa9df
---
M oozie/webstats/insert_hourly_pagecounts/insert_hourly_pagecounts.hql
1 file changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/analytics/refinery 
refs/changes/24/177224/1

diff --git 
a/oozie/webstats/insert_hourly_pagecounts/insert_hourly_pagecounts.hql 
b/oozie/webstats/insert_hourly_pagecounts/insert_hourly_pagecounts.hql
index dd61ff9..e26a31e 100644
--- a/oozie/webstats/insert_hourly_pagecounts/insert_hourly_pagecounts.hql
+++ b/oozie/webstats/insert_hourly_pagecounts/insert_hourly_pagecounts.hql
@@ -52,8 +52,13 @@
             AND SUBSTR(uri_path, 1, 6) = '/wiki/'
             AND (
                     (
-                        SUBSTR(ip, 1, 9) != '10.128.0.'
-                        AND SUBSTR(ip, 1, 11) NOT IN (
+                        SUBSTR(ip, 1, 8) NOT IN (
+                            '10.20.0.',
+                            '10.64.0.'
+                        ) AND SUBSTR(ip, 1, 9) NOT IN (
+                            '10.128.0.',
+                            '10.64.32.'
+                        ) AND SUBSTR(ip, 1, 11) NOT IN (
                             '208.80.152.',
                             '208.80.153.',
                             '208.80.154.',

-- 
To view, visit https://gerrit.wikimedia.org/r/177224
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ef0ef2a6bdd16c7f00f56216df47b18df2aa9df
Gerrit-PatchSet: 1
Gerrit-Project: analytics/refinery
Gerrit-Branch: master
Gerrit-Owner: QChris <[email protected]>
Gerrit-Reviewer: Ottomata <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to