jenkins-bot has submitted this change and it was merged.
Change subject: article: Fix distance between image and text (landscape image &
non flipped)
......................................................................
article: Fix distance between image and text (landscape image & non flipped)
Change-Id: I4fb6891cd89546b6a55b6952be7e1a6df41fa0b5
---
M resources/ext.popups.renderer.article.js
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Werdna: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/ext.popups.renderer.article.js
b/resources/ext.popups.renderer.article.js
index c2c62d3..1804d96 100644
--- a/resources/ext.popups.renderer.article.js
+++ b/resources/ext.popups.renderer.article.js
@@ -21,7 +21,8 @@
w: 300 // Exact Width
},
landscapePopupWidth: 450, // Exact width of a landscape popup
- portraitPopupWidth: 300 // Exact width of a portrait popup
+ portraitPopupWidth: 300, // Exact width of a portrait popup
+ pokeySize: 8 // Height of the triangle used to point at the link
};
/**
@@ -461,7 +462,7 @@
if ( !flippedY && !tall && cache.settings.thumbnail.height <
article.SIZES.landscapeImage.h ) {
$( '.mwe-popups-extract').css(
'margin-top',
- cache.settings.thumbnail.height + 6
+ cache.settings.thumbnail.height -
article.SIZES.pokeySize
);
}
--
To view, visit https://gerrit.wikimedia.org/r/174634
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4fb6891cd89546b6a55b6952be7e1a6df41fa0b5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <[email protected]>
Gerrit-Reviewer: AndyRussG <[email protected]>
Gerrit-Reviewer: Werdna <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits