Christopher Johnson (WMDE) has submitted this change and it was merged.
Change subject: remove unused methods from BurndownDataDate
......................................................................
remove unused methods from BurndownDataDate
fix tests
Change-Id: Icc9da90452df6699b5821519bab94561506e4b4e
---
M src/tests/BurndownDataDateTest.php
M src/util/BurndownDataDate.php
2 files changed, 0 insertions(+), 30 deletions(-)
Approvals:
Christopher Johnson (WMDE): Verified; Looks good to me, approved
diff --git a/src/tests/BurndownDataDateTest.php
b/src/tests/BurndownDataDateTest.php
index c50d5b2..a3ad813 100644
--- a/src/tests/BurndownDataDateTest.php
+++ b/src/tests/BurndownDataDateTest.php
@@ -20,24 +20,4 @@
$total = $date->sumTasksTotal($current, $previous);
$this->assertEquals(13, $total);
}
-
- public function testSumTasksRemaining() {
- $date = new BurndownDataDate('test date');
- $previous = id(new BurndownDataDate('monday'));
- $previous->setTasksRemaining('5');
- $current = id(new BurndownDataDate('tuesday'));
- $current->setTasksRemaining('2');
- $total = $date->sumTasksRemaining($current, $previous);
- $this->assertEquals(7, $total);
- }
-
- public function testSumPointsRemaining() {
- $date = new BurndownDataDate('test date');
- $previous = id(new BurndownDataDate('monday'));
- $previous->setPointsRemaining('5');
- $current = id(new BurndownDataDate('tuesday'));
- $current->setPointsRemaining('2');
- $total = $date->sumPointsRemaining($current, $previous);
- $this->assertEquals(7, $total);
- }
}
\ No newline at end of file
diff --git a/src/util/BurndownDataDate.php b/src/util/BurndownDataDate.php
index 453711a..6d9e51d 100644
--- a/src/util/BurndownDataDate.php
+++ b/src/util/BurndownDataDate.php
@@ -147,16 +147,6 @@
return $current->points_total;
}
- public function sumTasksRemaining($added, $closed) {
- $this->tasks_remaining = $added - $closed;
- return $this->tasks_remaining;
- }
-
- public function sumPointsRemaining($current, $previous) {
- $current->points_remaining = $previous->points_remaining -
$current->points_remaining;
- return $current->points_remaining;
- }
-
public function changePoints($points, $old_point_value, $dates) {
// Adjust points for that day
$points = $points - $old_point_value;
--
To view, visit https://gerrit.wikimedia.org/r/177244
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc9da90452df6699b5821519bab94561506e4b4e
Gerrit-PatchSet: 2
Gerrit-Project: phabricator/extensions/Sprint
Gerrit-Branch: master
Gerrit-Owner: Christopher Johnson (WMDE) <[email protected]>
Gerrit-Reviewer: Christopher Johnson (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
