Cmcmahon has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177261
Change subject: QA: refactor nearby test for RSpec3 syntax
......................................................................
QA: refactor nearby test for RSpec3 syntax
test does not run, this is just formal
Change-Id: I9dc9e3f9380e7f77baa2ad77bf4b1c959e2bb65b
---
M tests/browser/features/nearby.feature
M tests/browser/features/step_definitions/nearby_steps.rb
2 files changed, 10 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/61/177261/1
diff --git a/tests/browser/features/nearby.feature
b/tests/browser/features/nearby.feature
index 75149f4..a95c17a 100644
--- a/tests/browser/features/nearby.feature
+++ b/tests/browser/features/nearby.feature
@@ -16,4 +16,4 @@
And I give permission for the page to access my location
And I should see at least one result in the nearby items list
When I click a nearby result
- Then I see the page preview overlay
+ Then I should see the page preview overlay
diff --git a/tests/browser/features/step_definitions/nearby_steps.rb
b/tests/browser/features/step_definitions/nearby_steps.rb
index 38d3890..73bdf81 100644
--- a/tests/browser/features/step_definitions/nearby_steps.rb
+++ b/tests/browser/features/step_definitions/nearby_steps.rb
@@ -4,17 +4,17 @@
end
end
-Then(/^I should see at least one result in the nearby items list$/) do
- on(ArticlePage) do |page|
- page.page_list_element.when_present(20).should be_visible
- page.page_list_element.link_element(class: "title").should be_visible
- end
-end
-
When(/^I click a nearby result$/) do
on(ArticlePage).page_list_element.when_present(20).link_element(class:
"title").click
end
-Then(/^I see the page preview overlay$/) do
- on(ArticlePage).overlay_element.when_present(20).div_element(class:
"content").should be_visible
+Then(/^I should see at least one result in the nearby items list$/) do
+ on(ArticlePage) do |page|
+ expect(page.page_list_element.when_present(20)).to be_visible
+ expect(page.page_list_element.link_element(class: "title")).to be_visible
+ end
+end
+
+Then(/^I should see the page preview overlay$/) do
+ expect(on(ArticlePage).overlay_element.when_present(20).div_element(class:
"content")).to be_visible
end
--
To view, visit https://gerrit.wikimedia.org/r/177261
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9dc9e3f9380e7f77baa2ad77bf4b1c959e2bb65b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
