Cmcmahon has uploaded a new change for review. https://gerrit.wikimedia.org/r/177263
Change subject: QA: refactor notifications test for RSpec3 syntax ...................................................................... QA: refactor notifications test for RSpec3 syntax Change-Id: I95d60d82cd5c1fc93de2ccdfeab73a83eaa522c4 --- M tests/browser/features/step_definitions/notification_steps.rb 1 file changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/63/177263/1 diff --git a/tests/browser/features/step_definitions/notification_steps.rb b/tests/browser/features/step_definitions/notification_steps.rb index 9f285a4..8d547a9 100644 --- a/tests/browser/features/step_definitions/notification_steps.rb +++ b/tests/browser/features/step_definitions/notification_steps.rb @@ -2,19 +2,19 @@ on(ArticlePage).notifications_button_element.when_present.click end -When(/^the notifications overlay appears$/) do - on(ArticlePage).notifications_overlay_element.when_present -end - -Then(/^I should see the notifications overlay$/) do - on(ArticlePage).notifications_overlay_element.when_present.should be_visible -end - When(/^I click the notifications overlay close button$/) do on(ArticlePage).notifications_overlay_close_button_element.when_present.click end +When(/^the notifications overlay appears$/) do + on(ArticlePage).notifications_overlay_element.when_present +end + Then(/^after (.+) seconds I should not see the notifications overlay$/) do |seconds| sleep seconds.to_i - on(ArticlePage).notifications_overlay_element.should_not be_visible + expect(on(ArticlePage).notifications_overlay_element).not_to be_visible +end + +Then(/^I should see the notifications overlay$/) do + expect(on(ArticlePage).notifications_overlay_element.when_present).to be_visible end -- To view, visit https://gerrit.wikimedia.org/r/177263 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I95d60d82cd5c1fc93de2ccdfeab73a83eaa522c4 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Cmcmahon <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
