jenkins-bot has submitted this change and it was merged.
Change subject: Fix possible crash when clicking link after activity closed.
......................................................................
Fix possible crash when clicking link after activity closed.
The link click event comes asynchronously from the WebView, and may be
caught after the activity is closed.
Change-Id: Iee75038f673d4512dafcbb6a0d191b1a192440ff
---
M wikipedia/src/main/java/org/wikipedia/page/PageViewFragmentInternal.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
BearND: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/wikipedia/src/main/java/org/wikipedia/page/PageViewFragmentInternal.java
b/wikipedia/src/main/java/org/wikipedia/page/PageViewFragmentInternal.java
index e6449c1..3e43df9 100644
--- a/wikipedia/src/main/java/org/wikipedia/page/PageViewFragmentInternal.java
+++ b/wikipedia/src/main/java/org/wikipedia/page/PageViewFragmentInternal.java
@@ -353,6 +353,9 @@
@Override
public void onInternalLinkClicked(PageTitle title) {
+ if (!isAdded()) {
+ return;
+ }
if (referenceDialog != null && referenceDialog.isShowing()) {
referenceDialog.dismiss();
}
--
To view, visit https://gerrit.wikimedia.org/r/177253
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee75038f673d4512dafcbb6a0d191b1a192440ff
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
Gerrit-Reviewer: BearND <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
