jenkins-bot has submitted this change and it was merged.
Change subject: QA: refactor pageactions_steps for RSpec3
......................................................................
QA: refactor pageactions_steps for RSpec3
Change-Id: I8b5604353ae30fa6bf09edfc50cec1901a8f8d12
---
M tests/browser/features/pageactions.feature
M tests/browser/features/pageactions_logged_in_but_new.feature
M tests/browser/features/step_definitions/pageactions_steps.rb
3 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Cmcmahon: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/browser/features/pageactions.feature
b/tests/browser/features/pageactions.feature
index 5eac92d..5178be4 100644
--- a/tests/browser/features/pageactions.feature
+++ b/tests/browser/features/pageactions.feature
@@ -10,7 +10,7 @@
Then I should see a drawer with message "Help improve this page!"
Scenario: Do not see - Upload Icon
- Then there is not an upload an image to this page button
+ Then I should not see an upload an image to this page button
Scenario: Receive notification message - Watchlist Icon
When I click the watch star
diff --git a/tests/browser/features/pageactions_logged_in_but_new.feature
b/tests/browser/features/pageactions_logged_in_but_new.feature
index 74f8405..12947f9 100644
--- a/tests/browser/features/pageactions_logged_in_but_new.feature
+++ b/tests/browser/features/pageactions_logged_in_but_new.feature
@@ -7,4 +7,4 @@
And I am at a random page
Scenario: I can not see the upload button
- Then there is not an upload an image to this page button
+ Then I should not see an upload an image to this page button
diff --git a/tests/browser/features/step_definitions/pageactions_steps.rb
b/tests/browser/features/step_definitions/pageactions_steps.rb
index 7fb6a6a..2485187 100644
--- a/tests/browser/features/step_definitions/pageactions_steps.rb
+++ b/tests/browser/features/step_definitions/pageactions_steps.rb
@@ -2,6 +2,6 @@
on(ArticlePage).edit_button_holder_element.when_present.click
end
-Then(/^there is not an upload an image to this page button$/) do
- on(ArticlePage).upload_button_element.should_not exist
+Then(/^I should not see an upload an image to this page button$/) do
+ expect(on(ArticlePage).upload_button_element).not_to be_visible
end
--
To view, visit https://gerrit.wikimedia.org/r/177265
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b5604353ae30fa6bf09edfc50cec1901a8f8d12
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: Cmcmahon <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
