jenkins-bot has submitted this change and it was merged.
Change subject: QA: interim check to sort steps alphabetically
......................................................................
QA: interim check to sort steps alphabetically
no changes to function or text
Change-Id: I92d48330d41f3e2bf065e1d9bb56768f9755d552
---
M tests/browser/features/step_definitions/search_steps.rb
1 file changed, 26 insertions(+), 26 deletions(-)
Approvals:
Cmcmahon: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/browser/features/step_definitions/search_steps.rb
b/tests/browser/features/step_definitions/search_steps.rb
index 1f9d074..e88becc 100644
--- a/tests/browser/features/step_definitions/search_steps.rb
+++ b/tests/browser/features/step_definitions/search_steps.rb
@@ -1,5 +1,5 @@
-Then(/^I see the search button$/) do
- on(ArticlePage).search_button_element.when_present.should be_visible
+When(/^I click a search result$/) do
+ on(ArticlePage).search_result_element.when_present.click
end
When(/^I click the placeholder search box$/) do
@@ -9,6 +9,22 @@
on(ArticlePage).wait_until do
on(ArticlePage).current_url.end_with? '#/search'
end
+end
+
+When(/^I click the search button$/) do
+ on(ArticlePage).search_button_element.when_present.click
+end
+
+When(/^I click the search in pages button$/) do
+ on(ArticlePage).search_within_pages_element.when_present.click
+end
+
+When(/^I press the enter key$/) do
+ on(ArticlePage).search_box2_element.when_present.send_keys :enter
+end
+
+When(/^I click the search overlay close button$/) do
+ on(ArticlePage).search_overlay_close_button_element.click
end
When(/^I type into search box "(.+)"$/) do |search_term|
@@ -27,34 +43,18 @@
on(ArticlePage).search_box_placeholder=search_term
end
-Then(/^search results should contain "(.+)"$/) do |text|
- on(ArticlePage).search_result_element.when_present.text.should == text
+Then(/^I don't see the search overlay$/) do
+ on(ArticlePage).search_overlay_element.should_not be_visible
+end
+
+Then(/^I see the search button$/) do
+ on(ArticlePage).search_button_element.when_present.should be_visible
end
Then(/^I see the search overlay$/) do
on(ArticlePage).search_overlay_element.should be_visible
end
-When(/^I click the search overlay close button$/) do
- on(ArticlePage).search_overlay_close_button_element.click
-end
-
-Then(/^I don't see the search overlay$/) do
- on(ArticlePage).search_overlay_element.should_not be_visible
-end
-
-When(/^I click a search result$/) do
- on(ArticlePage).search_result_element.when_present.click
-end
-
-When(/^I click the search in pages button$/) do
- on(ArticlePage).search_within_pages_element.when_present.click
-end
-
-When(/^I press the enter key$/) do
- on(ArticlePage).search_box2_element.when_present.send_keys :enter
-end
-
-When(/^I click the search button$/) do
- on(ArticlePage).search_button_element.when_present.click
+Then(/^search results should contain "(.+)"$/) do |text|
+ on(ArticlePage).search_result_element.when_present.text.should == text
end
--
To view, visit https://gerrit.wikimedia.org/r/177273
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I92d48330d41f3e2bf065e1d9bb56768f9755d552
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon <[email protected]>
Gerrit-Reviewer: Cmcmahon <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
